Jingga/oms-ContractManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-ContractManagement.git synced 2026-02-16 10:28:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix billing process

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-04-08 04:36:25 +02:00
parent 6a1693debf
commit 6922d3c5d3
3 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.github/user_bug_report.md vendored
View File

@ -8,9 +8,11 @@ assignees: ''
--- ---
# Bug Description # Bug Description
A clear and concise description of what the bug is. A clear and concise description of what the bug is.
# How to Reproduce # How to Reproduce
Steps to reproduce the behavior: Steps to reproduce the behavior:
1. Go to '...' 1. Go to '...'
@ -19,16 +21,20 @@ Steps to reproduce the behavior:
4. See error 4. See error
# Expected Behavior # Expected Behavior
A clear and concise description of what you expected to happen. A clear and concise description of what you expected to happen.
# Screenshots # Screenshots
If applicable, add screenshots to help explain your problem. If applicable, add screenshots to help explain your problem.
# System Information # System Information
- System: [e.g. PC or iPhone11, ...]
- OS: [e.g. iOS] - System: [e.g. PC or iPhone11, ...]
- Browser [e.g. chrome, safari] - OS: [e.g. iOS]
- KarakaVersion [e.g. 22] - Browser [e.g. chrome, safari]
- KarakaVersion [e.g. 22]
# Additional Information # Additional Information
Add any other context about the problem here. Add any other context about the problem here.

14
Controller/ApiController.php
View File

@ -81,10 +81,10 @@ final class ApiController extends Controller
private function validateContractCreate(RequestAbstract $request) : array private function validateContractCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['title'] = empty($request->getData('title'))) if (($val['title'] = !$request->hasData('title'))
|| ($val['start'] = empty($request->getData('start'))) || ($val['start'] = !$request->hasData('start'))
|| ($val['duration'] = empty($request->getData('duration'))) || ($val['duration'] = !$request->hasData('duration'))
|| ($val['type'] = empty($request->getData('type'))) || ($val['type'] = !$request->hasData('type'))
) { ) {
return $val; return $val;
} }
@ -232,7 +232,7 @@ final class ApiController extends Controller
private function validateContractTypeCreate(RequestAbstract $request) : array private function validateContractTypeCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['title'] = empty($request->getData('title'))) if (($val['title'] = !$request->hasData('title'))
) { ) {
return $val; return $val;
} }
@ -299,8 +299,8 @@ final class ApiController extends Controller
private function validateContractTypeL11nCreate(RequestAbstract $request) : array private function validateContractTypeL11nCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['title'] = empty($request->getData('title'))) if (($val['title'] = !$request->hasData('title'))
|| ($val['type'] = empty($request->getData('type'))) || ($val['type'] = !$request->hasData('type'))
) { ) {
return $val; return $val;
} }

2
tests/Controller/ApiControllerTest.php
View File

@ -72,7 +72,7 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
$permission = new AccountPermission(); $permission = new AccountPermission();
$permission->setUnit(1); $permission->setUnit(1);
$permission->setApp('backend'); $permission->setApp(2);
$permission->setPermission( $permission->setPermission(
PermissionType::READ PermissionType::READ
| PermissionType::CREATE | PermissionType::CREATE