static code analysis fixes

This commit is contained in:
Dennis Eichhorn 2022-04-05 20:04:47 +02:00
parent d4e6037cc6
commit d8694d02f1
2 changed files with 5 additions and 5 deletions

View File

@ -147,8 +147,8 @@ final class ApiController extends Controller
$comment = $this->createCommentFromRequest($request); $comment = $this->createCommentFromRequest($request);
$this->createModel($request->header->account, $comment, CommentMapper::class, 'comment', $request->getOrigin()); $this->createModel($request->header->account, $comment, CommentMapper::class, 'comment', $request->getOrigin());
if (!empty($request->getFiles() ?? []) if (!empty($request->getFiles())
|| !empty($request->getDataJson('media') ?? []) || !empty($request->getDataJson('media'))
) { ) {
$this->createCommentMedia($comment, $request); $this->createCommentMedia($comment, $request);
} }
@ -171,7 +171,7 @@ final class ApiController extends Controller
$path = $this->createCommentDir($comment); $path = $this->createCommentDir($comment);
$account = AccountMapper::get()->where('id', $request->header->account)->execute(); $account = AccountMapper::get()->where('id', $request->header->account)->execute();
if (!empty($uploadedFiles = $request->getFiles() ?? [])) { if (!empty($uploadedFiles = $request->getFiles())) {
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles( $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
[], [],
[], [],
@ -209,7 +209,7 @@ final class ApiController extends Controller
} }
} }
if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) { if (!empty($mediaFiles = $request->getDataJson('media'))) {
$collection = null; $collection = null;
foreach ($mediaFiles as $file) { foreach ($mediaFiles as $file) {

View File

@ -12,7 +12,7 @@
"friendsofphp/php-cs-fixer": ">=3.2", "friendsofphp/php-cs-fixer": ">=3.2",
"squizlabs/php_codesniffer": ">=3.6", "squizlabs/php_codesniffer": ">=3.6",
"phpmd/phpmd": ">=2.9", "phpmd/phpmd": ">=2.9",
"phpstan/phpstan": ">=0.12.58", "phpstan/phpstan": ">=1.5.4",
"phan/phan": ">=3.2.6" "phan/phan": ">=3.2.6"
}, },
"minimum-stability": "dev", "minimum-stability": "dev",