From bff89907195d3a36be86d2de9d4a9fea83247e12 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 12 Sep 2019 19:48:00 +0200 Subject: [PATCH] fix phpcs findings --- Admin/Install/Navigation.php | 20 +++++++-------- Admin/Installer.php | 18 +++++++------- Admin/Status.php | 18 +++++++------- Admin/Uninstaller.php | 18 +++++++------- Admin/Updater.php | 18 +++++++------- Controller/BackendController.php | 30 ++++++++++++++--------- Controller/Controller.php | 30 +++++++++++------------ Models/Client.php | 18 +++++++------- Models/ClientMapper.php | 22 ++++++++--------- Models/PermissionState.php | 18 +++++++------- Theme/Backend/Lang/Navigation.en.lang.php | 10 ++++---- Theme/Backend/Lang/en.lang.php | 10 ++++---- Theme/Backend/clients-create.tpl.php | 10 ++++---- Theme/Backend/clients-list.tpl.php | 10 ++++---- Theme/Backend/clients-profile.tpl.php | 10 ++++---- 15 files changed, 133 insertions(+), 127 deletions(-) diff --git a/Admin/Install/Navigation.php b/Admin/Install/Navigation.php index 6095d8d..3827887 100644 --- a/Admin/Install/Navigation.php +++ b/Admin/Install/Navigation.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Admin\Install - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Admin\Install + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\DataStorage\Database\DatabasePool; /** * Navigation class. * - * @package Modules\ClientManagement\Admin\Install - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Admin\Install + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Navigation { @@ -34,7 +34,7 @@ class Navigation * * @return void * - * @since 1.0.0 + * @since 1.0.0 */ public static function install(string $path, DatabasePool $dbPool) : void { diff --git a/Admin/Installer.php b/Admin/Installer.php index ea86258..e346286 100644 --- a/Admin/Installer.php +++ b/Admin/Installer.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\InstallerAbstract; /** * Installer class. * - * @package Modules\ClientManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Installer extends InstallerAbstract { diff --git a/Admin/Status.php b/Admin/Status.php index 1c2cc62..0225d00 100644 --- a/Admin/Status.php +++ b/Admin/Status.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\StatusAbstract; /** * Navigation class. * - * @package Modules\ClientManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Status extends StatusAbstract { diff --git a/Admin/Uninstaller.php b/Admin/Uninstaller.php index 1805503..fe8fb70 100644 --- a/Admin/Uninstaller.php +++ b/Admin/Uninstaller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UninstallerAbstract; /** * Uninstaller class. * - * @package Modules\ClientManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Uninstaller extends UninstallerAbstract { diff --git a/Admin/Updater.php b/Admin/Updater.php index 6b139ef..132df5c 100644 --- a/Admin/Updater.php +++ b/Admin/Updater.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UpdaterAbstract; /** * Updater class. * - * @package Modules\ClientManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Updater extends UpdaterAbstract { diff --git a/Controller/BackendController.php b/Controller/BackendController.php index ecb1770..d574f81 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -24,21 +24,23 @@ use phpOMS\Views\View; /** * ClientManagement class. * - * @package Modules\ClientManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ final class BackendController extends Controller { /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewClientManagementClientList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -54,13 +56,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewClientManagementClientCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -73,13 +77,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewClientManagementClientProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface diff --git a/Controller/Controller.php b/Controller/Controller.php index 31ddf9c..9fc0bb1 100644 --- a/Controller/Controller.php +++ b/Controller/Controller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -20,10 +20,10 @@ use phpOMS\Module\WebInterface; /** * ClientManagement class. * - * @package Modules\ClientManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Controller extends ModuleAbstract implements WebInterface { @@ -31,7 +31,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module path. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_PATH = __DIR__ . '/../'; @@ -39,7 +39,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module version. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_VERSION = '1.0.0'; @@ -47,7 +47,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module name. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_NAME = 'ClientManagement'; @@ -55,7 +55,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module id. * - * @var int + * @var int * @since 1.0.0 */ public const MODULE_ID = 1003100000; @@ -63,7 +63,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Providing. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $providing = []; @@ -71,7 +71,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Dependencies. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $dependencies = []; diff --git a/Models/Client.php b/Models/Client.php index 4ed760b..819afa7 100644 --- a/Models/Client.php +++ b/Models/Client.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -20,10 +20,10 @@ use Modules\Profile\Models\Profile; /** * Account class. * - * @package Modules\ClientManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Client { diff --git a/Models/ClientMapper.php b/Models/ClientMapper.php index 25155e4..87be03f 100644 --- a/Models/ClientMapper.php +++ b/Models/ClientMapper.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -25,7 +25,7 @@ final class ClientMapper extends DataMapperAbstract /** * Columns. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $columns = [ @@ -43,7 +43,7 @@ final class ClientMapper extends DataMapperAbstract /** * Primary table. * - * @var string + * @var string * @since 1.0.0 */ protected static string $table = 'clientmgmt_client'; @@ -51,7 +51,7 @@ final class ClientMapper extends DataMapperAbstract /** * Primary field name. * - * @var string + * @var string * @since 1.0.0 */ protected static string $primaryField = 'clientmgmt_client_id'; @@ -59,7 +59,7 @@ final class ClientMapper extends DataMapperAbstract /** * Created at column * - * @var string + * @var string * @since 1.0.0 */ protected static string $createdAt = 'clientmgmt_client_created_at'; @@ -67,7 +67,7 @@ final class ClientMapper extends DataMapperAbstract /** * Has one relation. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $ownsOne = [ @@ -80,7 +80,7 @@ final class ClientMapper extends DataMapperAbstract /** * Has many relation. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $hasMany = [ diff --git a/Models/PermissionState.php b/Models/PermissionState.php index 334592d..3f92583 100644 --- a/Models/PermissionState.php +++ b/Models/PermissionState.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ClientManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ClientManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Permision state enum. * - * @package Modules\ClientManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ClientManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class PermissionState extends Enum { diff --git a/Theme/Backend/Lang/Navigation.en.lang.php b/Theme/Backend/Lang/Navigation.en.lang.php index 4d9f58a..71a3769 100644 --- a/Theme/Backend/Lang/Navigation.en.lang.php +++ b/Theme/Backend/Lang/Navigation.en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['Navigation' => [ ]]; diff --git a/Theme/Backend/Lang/en.lang.php b/Theme/Backend/Lang/en.lang.php index a28eab5..943aaaa 100644 --- a/Theme/Backend/Lang/en.lang.php +++ b/Theme/Backend/Lang/en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['ClientManagement' => [ 'Accounting' => 'Accounting', diff --git a/Theme/Backend/clients-create.tpl.php b/Theme/Backend/clients-create.tpl.php index b70f9d2..e6a51f3 100644 --- a/Theme/Backend/clients-create.tpl.php +++ b/Theme/Backend/clients-create.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ /** * @var \phpOMS\Views\View $this diff --git a/Theme/Backend/clients-list.tpl.php b/Theme/Backend/clients-list.tpl.php index 444183e..95c19be 100644 --- a/Theme/Backend/clients-list.tpl.php +++ b/Theme/Backend/clients-list.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $footerView = new \phpOMS\Views\PaginationView($this->app, $this->request, $this->response); diff --git a/Theme/Backend/clients-profile.tpl.php b/Theme/Backend/clients-profile.tpl.php index 4ee7240..79b42cf 100644 --- a/Theme/Backend/clients-profile.tpl.php +++ b/Theme/Backend/clients-profile.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $client = $this->getData('client');