From 8e7da92ff121b61a0f84b6e67fb81697b4227f38 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 7 Feb 2019 00:05:31 +0100 Subject: [PATCH] phpcs+phpstan fixes --- Admin/Install/Navigation.php | 2 +- Controller/BackendController.php | 7 ++++--- Models/ClientMapper.php | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Admin/Install/Navigation.php b/Admin/Install/Navigation.php index 0489cb9..3b32baf 100644 --- a/Admin/Install/Navigation.php +++ b/Admin/Install/Navigation.php @@ -36,7 +36,7 @@ class Navigation * * @since 1.0.0 */ - public static function install(string $path = null, DatabasePool $dbPool = null) : void + public static function install(string $path, DatabasePool $dbPool) : void { \Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']); } diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 2c88aa1..2462bba 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -15,6 +15,7 @@ declare(strict_types=1); namespace Modules\ClientManagement\Controller; use Modules\ClientManagement\Models\ClientMapper; + use phpOMS\Contract\RenderableInterface; use phpOMS\Message\RequestAbstract; use phpOMS\Message\ResponseAbstract; @@ -40,7 +41,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewClientManagementClientList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewClientManagementClientList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/ClientManagement/Theme/Backend/clients-list'); @@ -62,7 +63,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewClientManagementClientCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewClientManagementClientCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/ClientManagement/Theme/Backend/clients-create'); @@ -81,7 +82,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewClientManagementClientProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewClientManagementClientProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/ClientManagement/Theme/Backend/clients-profile'); diff --git a/Models/ClientMapper.php b/Models/ClientMapper.php index 76b826d..4817cd8 100644 --- a/Models/ClientMapper.php +++ b/Models/ClientMapper.php @@ -78,7 +78,7 @@ final class ClientMapper extends DataMapperAbstract ]; /** * Has many relation. * - * @var array> + * @var array> * @since 1.0.0 */ protected static $hasMany = [