From 3fc5dec7172af61386d648e89afe24ee7ad31230 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Sat, 23 Sep 2023 12:50:40 +0000
Subject: [PATCH] fix tests

---
 .../Api/ApiControllerAttributeTrait.php       | 22 +++++++++----------
 tests/Controller/ApiControllerTest.php        |  4 ++++
 tests/Models/ClientTest.php                   | 10 ---------
 3 files changed, 15 insertions(+), 21 deletions(-)

diff --git a/tests/Controller/Api/ApiControllerAttributeTrait.php b/tests/Controller/Api/ApiControllerAttributeTrait.php
index 8572097..9c44de5 100755
--- a/tests/Controller/Api/ApiControllerAttributeTrait.php
+++ b/tests/Controller/Api/ApiControllerAttributeTrait.php
@@ -37,7 +37,7 @@ trait ApiControllerAttributeTrait
         $request->setData('name', 'test_name');
         $request->setData('language', ISO639x1Enum::_EN);
 
-        $this->module->apiClientAttributeTypeCreate($request, $response);
+        $this->attrModule->apiClientAttributeTypeCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -55,7 +55,7 @@ trait ApiControllerAttributeTrait
         $request->setData('type', '1');
         $request->setData('language', ISO639x1Enum::_DE);
 
-        $this->module->apiClientAttributeTypeL11nCreate($request, $response);
+        $this->attrModule->apiClientAttributeTypeL11nCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -75,7 +75,7 @@ trait ApiControllerAttributeTrait
         $request->setData('language', ISO639x1Enum::_DE);
         $request->setData('country', ISO3166TwoEnum::_DEU);
 
-        $this->module->apiClientAttributeValueCreate($request, $response);
+        $this->attrModule->apiClientAttributeValueCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -94,7 +94,7 @@ trait ApiControllerAttributeTrait
         $request->setData('language', ISO639x1Enum::_DE);
         $request->setData('country', ISO3166TwoEnum::_DEU);
 
-        $this->module->apiClientAttributeValueCreate($request, $response);
+        $this->attrModule->apiClientAttributeValueCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -113,7 +113,7 @@ trait ApiControllerAttributeTrait
         $request->setData('language', ISO639x1Enum::_DE);
         $request->setData('country', ISO3166TwoEnum::_DEU);
 
-        $this->module->apiClientAttributeValueCreate($request, $response);
+        $this->attrModule->apiClientAttributeValueCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -132,7 +132,7 @@ trait ApiControllerAttributeTrait
         $request->setData('language', ISO639x1Enum::_DE);
         $request->setData('country', ISO3166TwoEnum::_DEU);
 
-        $this->module->apiClientAttributeValueCreate($request, $response);
+        $this->attrModule->apiClientAttributeValueCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -150,7 +150,7 @@ trait ApiControllerAttributeTrait
         $request->setData('value', '1');
         $request->setData('type', '1');
 
-        $this->module->apiClientAttributeCreate($request, $response);
+        $this->attrModule->apiClientAttributeCreate($request, $response);
         self::assertGreaterThan(0, $response->get('')['response']->id);
     }
 
@@ -166,7 +166,7 @@ trait ApiControllerAttributeTrait
         $request->header->account = 1;
         $request->setData('invalid', '1');
 
-        $this->module->apiClientAttributeValueCreate($request, $response);
+        $this->attrModule->apiClientAttributeValueCreate($request, $response);
         self::assertEquals(RequestStatusCode::R_400, $response->header->status);
     }
 
@@ -182,7 +182,7 @@ trait ApiControllerAttributeTrait
         $request->header->account = 1;
         $request->setData('invalid', '1');
 
-        $this->module->apiClientAttributeTypeCreate($request, $response);
+        $this->attrModule->apiClientAttributeTypeCreate($request, $response);
         self::assertEquals(RequestStatusCode::R_400, $response->header->status);
     }
 
@@ -198,7 +198,7 @@ trait ApiControllerAttributeTrait
         $request->header->account = 1;
         $request->setData('invalid', '1');
 
-        $this->module->apiClientAttributeTypeL11nCreate($request, $response);
+        $this->attrModule->apiClientAttributeTypeL11nCreate($request, $response);
         self::assertEquals(RequestStatusCode::R_400, $response->header->status);
     }
 
@@ -214,7 +214,7 @@ trait ApiControllerAttributeTrait
         $request->header->account = 1;
         $request->setData('invalid', '1');
 
-        $this->module->apiClientAttributeCreate($request, $response);
+        $this->attrModule->apiClientAttributeCreate($request, $response);
         self::assertEquals(RequestStatusCode::R_400, $response->header->status);
     }
 }
diff --git a/tests/Controller/ApiControllerTest.php b/tests/Controller/ApiControllerTest.php
index 802ff5d..4521c06 100755
--- a/tests/Controller/ApiControllerTest.php
+++ b/tests/Controller/ApiControllerTest.php
@@ -45,6 +45,8 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
      */
     protected ModuleAbstract $module;
 
+    protected ModuleAbstract $attrModule;
+
     /**
      * {@inheritdoc}
      */
@@ -86,8 +88,10 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
         $this->app->router = new WebRouter();
 
         $this->module = $this->app->moduleManager->get('ClientManagement');
+        $this->attrModule = $this->app->moduleManager->get('ClientManagement');
 
         TestUtils::setMember($this->module, 'app', $this->app);
+        TestUtils::setMember($this->attrModule, 'app', $this->app);
     }
 
     use ApiControllerClientTrait;
diff --git a/tests/Models/ClientTest.php b/tests/Models/ClientTest.php
index 5dfddb0..bd7512a 100755
--- a/tests/Models/ClientTest.php
+++ b/tests/Models/ClientTest.php
@@ -77,16 +77,6 @@ final class ClientTest extends \PHPUnit\Framework\TestCase
         self::assertEquals(2, $this->client->getType());
     }
 
-    /**
-     * @covers Modules\ClientManagement\Models\Client
-     * @group module
-     */
-    public function testFileInputOutput() : void
-    {
-        $this->client->addFile($temp = new Media());
-        self::assertCount(1, $this->client->files);
-    }
-
     /**
      * @covers Modules\ClientManagement\Models\Client
      * @group module