Jingga/oms-Calendar
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Calendar.git synced 2026-02-15 16:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phpcs+phpstan fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-02-07 00:05:31 +01:00
parent ce7587ea28
commit bc15be0084
6 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Admin/Install/Navigation.php
View File

@ -36,7 +36,7 @@ class Navigation
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public static function install(string $path = null, DatabasePool $dbPool = null) : void public static function install(string $path, DatabasePool $dbPool) : void
{ {
\Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']); \Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']);
} }

13
Controller/BackendController.php
View File

@ -17,6 +17,7 @@ namespace Modules\Calendar\Controller;
use Modules\Calendar\Models\CalendarMapper; use Modules\Calendar\Models\CalendarMapper;
use phpOMS\Asset\AssetType; use phpOMS\Asset\AssetType;
use phpOMS\Contract\RenderableInterface;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract; use phpOMS\Message\ResponseAbstract;
use phpOMS\Stdlib\Base\SmartDateTime; use phpOMS\Stdlib\Base\SmartDateTime;
@ -37,16 +38,16 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response * @param ResponseAbstract $response Response
* @param mixed $data Generic data * @param mixed $data Generic data
* *
* @return \Serializable * @return RenderableInterface
* *
* @since 1.0.0 * @since 1.0.0
* @codeCoverageIgnore * @codeCoverageIgnore
*/ */
public function viewCalendarDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable public function viewCalendarDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{ {
$view = new View($this->app, $request, $response); $view = new View($this->app, $request, $response);
/** @var Head $head */ /** @var \phpOMS\Model\Html\Head $head */
$head = $response->get('Content')->getData('head'); $head = $response->get('Content')->getData('head');
$head->addAsset(AssetType::CSS, '/Modules/Calendar/Theme/Backend/css/styles.css'); $head->addAsset(AssetType::CSS, '/Modules/Calendar/Theme/Backend/css/styles.css');
@ -68,14 +69,14 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response * @param ResponseAbstract $response Response
* @param mixed $data Generic data * @param mixed $data Generic data
* *
* @return \Serializable * @return RenderableInterface
* *
* @since 1.0.0 * @since 1.0.0
* @codeCoverageIgnore * @codeCoverageIgnore
*/ */
public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{ {
/** @var Head $head */ /** @var \phpOMS\Model\Html\Head $head */
$head = $response->get('Content')->getData('head'); $head = $response->get('Content')->getData('head');
$head->addAsset(AssetType::CSS, '/Modules/Calendar/Theme/Backend/css/styles.css'); $head->addAsset(AssetType::CSS, '/Modules/Calendar/Theme/Backend/css/styles.css');

1
Controller/Controller.php
View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\Calendar\Controller; namespace Modules\Calendar\Controller;
use phpOMS\Module\ModuleAbstract; use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\WebInterface; use phpOMS\Module\WebInterface;

4
Models/Calendar.php
View File

@ -54,7 +54,7 @@ class Calendar
/** /**
* Created at. * Created at.
* *
* @var \Datetime * @var \DateTime
* @since 1.0.0 * @since 1.0.0
*/ */
private $createdAt = null; private $createdAt = null;
@ -62,7 +62,7 @@ class Calendar
/** /**
* Current date of the calendar. * Current date of the calendar.
* *
* @var \Datetime * @var \DateTime
* @since 1.0.0 * @since 1.0.0
*/ */
private $date = null; private $date = null;

5
Models/CalendarMapper.php
View File

@ -53,11 +53,6 @@ final class CalendarMapper extends DataMapperAbstract
* *
* @var array<string, array<string, null|string>> * @var array<string, array<string, null|string>>
* @since 1.0.0 * @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/ */
protected static $hasMany = [ protected static $hasMany = [
'events' => [ 'events' => [

14
Models/Event.php
View File

@ -56,7 +56,7 @@ class Event
/** /**
* Created. * Created.
* *
* @var \Datetime * @var \DateTime
* @since 1.0.0 * @since 1.0.0
*/ */
private $createdAt = null; private $createdAt = null;
@ -178,19 +178,13 @@ class Event
/** /**
* @param Account $person Person to add * @param Account $person Person to add
* *
* @return int Account id/position * @return void
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function addPerson(Account $person) public function addPerson(Account $person) : void
{ {
$this->people[] = $person; $this->people[$person->getId()] = $person;
\end($this->people);
$key = \key($this->people);
\reset($this->people);
return $key;
} }
/** /**