Jingga/oms-Billing
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Billing.git synced 2026-02-17 16:58:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2024-04-25 14:29:09 +00:00
parent 5352da7484
commit 811c9a0381
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Controller/ApiBillController.php
View File

@ -926,7 +926,7 @@ final class ApiBillController extends Controller
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function apiBillElementCreate(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void public function apiBillElementCreate(HttpRequest $request, ResponseAbstract $response, array $data = []) : void
{ {
if (!empty($val = $this->validateBillElementCreate($request))) { if (!empty($val = $this->validateBillElementCreate($request))) {
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
@ -959,7 +959,7 @@ final class ApiBillController extends Controller
/** /**
* Method to create a bill element from request. * Method to create a bill element from request.
* *
* @param RequestAbstract $request Request * @param HttpRequest $request Request
* @param ResponseAbstract $response Response * @param ResponseAbstract $response Response
* @param Bill $bill Bill to create element for * @param Bill $bill Bill to create element for
* @param array $data Generic data * @param array $data Generic data
@ -968,7 +968,7 @@ final class ApiBillController extends Controller
* *
* @since 1.0.0 * @since 1.0.0
*/ */
private function createBillElementFromRequest(RequestAbstract $request, ResponseAbstract $response, Bill $bill, $data = null) : BillElement private function createBillElementFromRequest(HttpRequest $request, ResponseAbstract $response, Bill $bill, $data = null) : BillElement
{ {
// @todo handle text element // @todo handle text element

6
Models/SalesBillMapper.php
View File

@ -385,7 +385,7 @@ final class SalesBillMapper extends BillMapper
$hasData = false; $hasData = false;
foreach ($results as $result) { foreach ($results as $result) {
if ($result !== '0' || ((int) $result) > 0) { if (!empty($result)) {
$hasData = true; $hasData = true;
break; break;
} }
@ -434,9 +434,7 @@ final class SalesBillMapper extends BillMapper
$hasData = false; $hasData = false;
foreach ($results as $result) { foreach ($results as $result) {
if ($result['net_sales'] !== '0' || ((int) $result['net_sales']) > 0 if (!empty($result['net_sales']) || !empty($result['net_costs'])) {
|| $result['net_costs'] !== '0' || ((int) $result['net_costs']) > 0
) {
$hasData = true; $hasData = true;
break; break;
} }