From 48792594a5043e324fcf72c7bd3ff52ddc14d649 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 12 Sep 2019 19:48:00 +0200 Subject: [PATCH] fix phpcs findings --- Admin/Install/Navigation.php | 20 ++++++------- Admin/Installer.php | 18 ++++++------ Admin/Status.php | 18 ++++++------ Admin/Uninstaller.php | 18 ++++++------ Admin/Updater.php | 18 ++++++------ Controller/BackendController.php | 30 +++++++++++-------- Controller/Controller.php | 30 +++++++++---------- Models/Invoice.php | 32 ++++++++++----------- Models/InvoiceElement.php | 18 ++++++------ Models/InvoiceMapper.php | 22 +++++++------- Models/InvoiceStatus.php | 18 ++++++------ Models/InvoiceType.php | 18 ++++++------ Models/PermissionState.php | 18 ++++++------ Theme/Backend/Lang/Navigation.en.lang.php | 10 +++---- Theme/Backend/Lang/en.lang.php | 10 +++---- Theme/Backend/invoice-archive.tpl.php | 10 +++---- Theme/Backend/invoice-create.tpl.php | 10 +++---- Theme/Backend/invoice-list.tpl.php | 10 +++---- Theme/Backend/invoice-single.tpl.php | 10 +++---- Theme/Backend/purchase-invoice-list.tpl.php | 10 +++---- 20 files changed, 177 insertions(+), 171 deletions(-) diff --git a/Admin/Install/Navigation.php b/Admin/Install/Navigation.php index dd5d6bd..ea0aa29 100644 --- a/Admin/Install/Navigation.php +++ b/Admin/Install/Navigation.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Admin\Install - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Admin\Install + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\DataStorage\Database\DatabasePool; /** * Navigation class. * - * @package Modules\Billing\Admin\Install - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Admin\Install + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Navigation { @@ -34,7 +34,7 @@ class Navigation * * @return void * - * @since 1.0.0 + * @since 1.0.0 */ public static function install(string $path, DatabasePool $dbPool) : void { diff --git a/Admin/Installer.php b/Admin/Installer.php index a15151b..fd1aefc 100644 --- a/Admin/Installer.php +++ b/Admin/Installer.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\InstallerAbstract; /** * Installer class. * - * @package Modules\Billing\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Installer extends InstallerAbstract { diff --git a/Admin/Status.php b/Admin/Status.php index 5bd2eeb..70e33d7 100644 --- a/Admin/Status.php +++ b/Admin/Status.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\StatusAbstract; /** * Navigation class. * - * @package Modules\Billing\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Status extends StatusAbstract { diff --git a/Admin/Uninstaller.php b/Admin/Uninstaller.php index ba58117..deea13c 100644 --- a/Admin/Uninstaller.php +++ b/Admin/Uninstaller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UninstallerAbstract; /** * Uninstaller class. * - * @package Modules\Billing\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Uninstaller extends UninstallerAbstract { diff --git a/Admin/Updater.php b/Admin/Updater.php index 3c25447..0b0cfac 100644 --- a/Admin/Updater.php +++ b/Admin/Updater.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UpdaterAbstract; /** * Updater class. * - * @package Modules\Billing\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Updater extends UpdaterAbstract { diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 709f794..940ae4d 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -22,22 +22,24 @@ use phpOMS\Views\View; /** * Billing class. * - * @package Modules\Billing - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ final class BackendController extends Controller { /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewBillingInvoiceList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -50,13 +52,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewBillingInvoiceCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -69,13 +73,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewBillingPurchaInvoiceList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface diff --git a/Controller/Controller.php b/Controller/Controller.php index 73698f1..ea4212d 100644 --- a/Controller/Controller.php +++ b/Controller/Controller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -20,10 +20,10 @@ use phpOMS\Module\WebInterface; /** * Billing class. * - * @package Modules\Billing - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Controller extends ModuleAbstract implements WebInterface { @@ -31,7 +31,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module path. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_PATH = __DIR__ . '/../'; @@ -39,7 +39,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module version. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_VERSION = '1.0.0'; @@ -47,7 +47,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module name. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_NAME = 'Billing'; @@ -55,7 +55,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module id. * - * @var int + * @var int * @since 1.0.0 */ public const MODULE_ID = 1005100000; @@ -63,7 +63,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Providing. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $providing = []; @@ -71,7 +71,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Dependencies. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $dependencies = []; diff --git a/Models/Invoice.php b/Models/Invoice.php index feca6f0..9832329 100644 --- a/Models/Invoice.php +++ b/Models/Invoice.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -20,10 +20,10 @@ use phpOMS\Localization\Money; /** * Invoice class. * - * @package Modules\Billing\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Invoice implements \JsonSerializable { @@ -32,7 +32,7 @@ class Invoice implements \JsonSerializable /** * Number ID. * - * @var string + * @var string * @since 1.0.0 */ private string $number = ''; @@ -40,7 +40,7 @@ class Invoice implements \JsonSerializable /** * Invoice type. * - * @var int + * @var int * @since 1.0.0 */ private int $type = InvoiceType::BILL; @@ -48,7 +48,7 @@ class Invoice implements \JsonSerializable /** * Invoice status. * - * @var int + * @var int * @since 1.0.0 */ private int $status = InvoiceStatus::DRAFT; @@ -56,7 +56,7 @@ class Invoice implements \JsonSerializable /** * Invoice created at. * - * @var null|\DateTime + * @var null|\DateTime * @since 1.0.0 */ private ?\DateTime $createdAt = null; @@ -64,7 +64,7 @@ class Invoice implements \JsonSerializable /** * Invoice send at. * - * @var null|\DateTime + * @var null|\DateTime * @since 1.0.0 */ private ?\DateTime $send = null; @@ -100,7 +100,7 @@ class Invoice implements \JsonSerializable /** * Person refering for this order. * - * @var int + * @var int * @since 1.0.0 */ private int $referer = 0; @@ -142,7 +142,7 @@ class Invoice implements \JsonSerializable /** * Reference to other invoice (delivery note/credit note etc). * - * @var int + * @var int * @since 1.0.0 */ private int $reference = 0; diff --git a/Models/InvoiceElement.php b/Models/InvoiceElement.php index 62a673f..f17d989 100644 --- a/Models/InvoiceElement.php +++ b/Models/InvoiceElement.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Localization\Money; /** * Invoice class. * - * @package Modules\Billing\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class InvoiceElement implements \JsonSerializable { diff --git a/Models/InvoiceMapper.php b/Models/InvoiceMapper.php index 68e3262..c0e07b5 100644 --- a/Models/InvoiceMapper.php +++ b/Models/InvoiceMapper.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,17 +19,17 @@ use phpOMS\DataStorage\Database\DataMapperAbstract; /** * Mapper class. * - * @package Modules\Billing - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ final class InvoiceMapper extends DataMapperAbstract { /** * Primary field name. * - * @var string + * @var string * @since 1.0.0 */ protected static string $primaryField = 'billing_invoice_id'; @@ -37,7 +37,7 @@ final class InvoiceMapper extends DataMapperAbstract /** * Primary table. * - * @var string + * @var string * @since 1.0.0 */ protected static string $table = 'billing_invoice'; diff --git a/Models/InvoiceStatus.php b/Models/InvoiceStatus.php index c2324ef..c397827 100644 --- a/Models/InvoiceStatus.php +++ b/Models/InvoiceStatus.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Task type enum. * - * @package Modules\Billing\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class InvoiceStatus extends Enum { diff --git a/Models/InvoiceType.php b/Models/InvoiceType.php index c56158d..6d7d13f 100644 --- a/Models/InvoiceType.php +++ b/Models/InvoiceType.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Task type enum. * - * @package Modules\Billing\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class InvoiceType extends Enum { diff --git a/Models/PermissionState.php b/Models/PermissionState.php index 6e4c73e..4f2321a 100644 --- a/Models/PermissionState.php +++ b/Models/PermissionState.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\Billing - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\Billing + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Permision state enum. * - * @package Modules\Billing - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\Billing + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class PermissionState extends Enum { diff --git a/Theme/Backend/Lang/Navigation.en.lang.php b/Theme/Backend/Lang/Navigation.en.lang.php index 9628643..af193e5 100644 --- a/Theme/Backend/Lang/Navigation.en.lang.php +++ b/Theme/Backend/Lang/Navigation.en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['Navigation' => [ 'Billing' => 'Billing', diff --git a/Theme/Backend/Lang/en.lang.php b/Theme/Backend/Lang/en.lang.php index 73d47bd..7ce1b4f 100644 --- a/Theme/Backend/Lang/en.lang.php +++ b/Theme/Backend/Lang/en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['Billing' => [ 'Address' => 'Address', diff --git a/Theme/Backend/invoice-archive.tpl.php b/Theme/Backend/invoice-archive.tpl.php index e17cb52..69d3077 100644 --- a/Theme/Backend/invoice-archive.tpl.php +++ b/Theme/Backend/invoice-archive.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ /** * @var \phpOMS\Views\View $this diff --git a/Theme/Backend/invoice-create.tpl.php b/Theme/Backend/invoice-create.tpl.php index 9f5d0a2..786def5 100644 --- a/Theme/Backend/invoice-create.tpl.php +++ b/Theme/Backend/invoice-create.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ /** * @var \phpOMS\Views\View $this diff --git a/Theme/Backend/invoice-list.tpl.php b/Theme/Backend/invoice-list.tpl.php index 6ff9fa1..a80b976 100644 --- a/Theme/Backend/invoice-list.tpl.php +++ b/Theme/Backend/invoice-list.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $footerView = new \phpOMS\Views\PaginationView($this->app, $this->request, $this->response); diff --git a/Theme/Backend/invoice-single.tpl.php b/Theme/Backend/invoice-single.tpl.php index e17cb52..69d3077 100644 --- a/Theme/Backend/invoice-single.tpl.php +++ b/Theme/Backend/invoice-single.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ /** * @var \phpOMS\Views\View $this diff --git a/Theme/Backend/purchase-invoice-list.tpl.php b/Theme/Backend/purchase-invoice-list.tpl.php index 668f5ff..b9321ba 100644 --- a/Theme/Backend/purchase-invoice-list.tpl.php +++ b/Theme/Backend/purchase-invoice-list.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $footerView = new \phpOMS\Views\PaginationView($this->app, $this->request, $this->response);