Jingga/oms-Billing
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Billing.git synced 2026-02-18 17:28:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug and media fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-10-29 14:49:55 +02:00
parent 0506ae8415
commit 3d27009178
12 changed files with 73 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Admin/Install/Media.install.json
View File

@ -26,6 +26,7 @@
"name": "Default", "name": "Default",
"virtualPath": "/Modules/Billing/Templates", "virtualPath": "/Modules/Billing/Templates",
"path": "/Modules/Media/Files/Modules/Billing/Templates/Default", "path": "/Modules/Media/Files/Modules/Billing/Templates/Default",
"fixed_names": true,
"files": [ "files": [
"/Modules/Billing/Admin/Install/Media" "/Modules/Billing/Admin/Install/Media"
], ],

1
Models/Bill.php
View File

@ -18,7 +18,6 @@ use Modules\Admin\Models\Account;
use Modules\Admin\Models\NullAccount; use Modules\Admin\Models\NullAccount;
use Modules\ClientManagement\Models\Client; use Modules\ClientManagement\Models\Client;
use Modules\Media\Models\Media; use Modules\Media\Models\Media;
use Modules\Media\Models\NullMedia;
use Modules\SupplierManagement\Models\Supplier; use Modules\SupplierManagement\Models\Supplier;
use phpOMS\Localization\ISO4217CharEnum; use phpOMS\Localization\ISO4217CharEnum;
use phpOMS\Localization\Money; use phpOMS\Localization\Money;

2
tests/Bootstrap.php
View File

@ -392,4 +392,4 @@ function phpServe() : void
}); });
} }
phpServe(); \phpServe();

9
tests/Controller/ApiControllerTest.php
View File

@ -16,22 +16,21 @@ namespace Modules\Billing\tests\Controller;
use Model\CoreSettings; use Model\CoreSettings;
use Modules\Admin\Models\AccountPermission; use Modules\Admin\Models\AccountPermission;
use Modules\Billing\Models\AuditMapper;
use phpOMS\Account\Account; use phpOMS\Account\Account;
use phpOMS\Account\AccountManager; use phpOMS\Account\AccountManager;
use phpOMS\Account\PermissionType; use phpOMS\Account\PermissionType;
use phpOMS\Application\ApplicationAbstract; use phpOMS\Application\ApplicationAbstract;
use phpOMS\Dispatcher\Dispatcher; use phpOMS\Dispatcher\Dispatcher;
use phpOMS\Event\EventManager; use phpOMS\Event\EventManager;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\ModuleManager;
use phpOMS\Router\WebRouter;
use phpOMS\Utils\TestUtils;
use phpOMS\Message\Http\HttpRequest; use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\HttpResponse; use phpOMS\Message\Http\HttpResponse;
use phpOMS\Message\Http\RequestStatusCode; use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\ModuleManager;
use phpOMS\Router\WebRouter;
use phpOMS\Uri\HttpUri; use phpOMS\Uri\HttpUri;
use phpOMS\Utils\RnG\DateTime; use phpOMS\Utils\RnG\DateTime;
use phpOMS\Utils\TestUtils;
/** /**
* @testdox Modules\tests\Billing\Controller\ApiControllerTest: Billing api controller * @testdox Modules\tests\Billing\Controller\ApiControllerTest: Billing api controller

1
tests/Models/BillElementTest.php
View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Billing\tests\Models; namespace Modules\Billing\tests\Models;
use Modules\Billing\Models\BillElement; use Modules\Billing\Models\BillElement;
use phpOMS\Localization\ISO4217CharEnum;
/** /**
* @internal * @internal

6
tests/Models/BillTest.php
View File

@ -49,9 +49,9 @@ final class BillTest extends \PHPUnit\Framework\TestCase
self::assertEquals(0, $this->bill->type); self::assertEquals(0, $this->bill->type);
self::assertInstanceOf('\DateTimeImmutable', $this->bill->createdAt); self::assertInstanceOf('\DateTimeImmutable', $this->bill->createdAt);
self::assertInstanceOf('\DateTime', $this->bill->performanceDate); self::assertInstanceOf('\DateTime', $this->bill->performanceDate);
self::assertEquals(null, $this->bill->send); self::assertNull($this->bill->send);
self::assertEquals(null, $this->bill->client); self::assertNull($this->bill->client);
self::assertEquals(null, $this->bill->supplier); self::assertNull($this->bill->supplier);
self::assertEquals([], $this->bill->getVouchers()); self::assertEquals([], $this->bill->getVouchers());
self::assertEquals([], $this->bill->getTrackings()); self::assertEquals([], $this->bill->getTrackings());
self::assertEquals([], $this->bill->getMediaByType(0)); self::assertEquals([], $this->bill->getMediaByType(0));

5
tests/Models/PurchaseBillMapperTest.php
View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Billing\tests\Models; namespace Modules\Billing\tests\Models;
use Modules\Billing\Models\PurchaseBillMapper; use Modules\Billing\Models\PurchaseBillMapper;
use phpOMS\Utils\TestUtils;
/** /**
* @testdox Modules\Billing\tests\Models\PurchaseBillMapperTest: App database mapper * @testdox Modules\Billing\tests\Models\PurchaseBillMapperTest: App database mapper
@ -75,7 +74,7 @@ final class PurchaseBillMapperTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGetLastOrderDateByItemIdInvalid() : void public function testGetLastOrderDateByItemIdInvalid() : void
{ {
self::assertEquals(null, PurchaseBillMapper::getLastOrderDateByItemId(99999)); self::assertNull(PurchaseBillMapper::getLastOrderDateByItemId(99999));
} }
/** /**
@ -84,7 +83,7 @@ final class PurchaseBillMapperTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGetLastOrderDateBySupplierIdInvalid() : void public function testGetLastOrderDateBySupplierIdInvalid() : void
{ {
self::assertEquals(null, PurchaseBillMapper::getLastOrderDateBySupplierId(99999)); self::assertNull(PurchaseBillMapper::getLastOrderDateBySupplierId(99999));
} }
/** /**

5
tests/Models/SalesBillMapperTest.php
View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Billing\tests\Models; namespace Modules\Billing\tests\Models;
use Modules\Billing\Models\SalesBillMapper; use Modules\Billing\Models\SalesBillMapper;
use phpOMS\Utils\TestUtils;
/** /**
* @testdox Modules\Billing\tests\Models\SalesBillMapperTest: App database mapper * @testdox Modules\Billing\tests\Models\SalesBillMapperTest: App database mapper
@ -75,7 +74,7 @@ final class SalesBillMapperTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGetLastOrderDateByItemIdInvalid() : void public function testGetLastOrderDateByItemIdInvalid() : void
{ {
self::assertEquals(null, SalesBillMapper::getLastOrderDateByItemId(99999)); self::assertNull(SalesBillMapper::getLastOrderDateByItemId(99999));
} }
/** /**
@ -84,7 +83,7 @@ final class SalesBillMapperTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGetLastOrderDateByClientIdInvalid() : void public function testGetLastOrderDateByClientIdInvalid() : void
{ {
self::assertEquals(null, SalesBillMapper::getLastOrderDateByClientId(99999)); self::assertNull(SalesBillMapper::getLastOrderDateByClientId(99999));
} }
/** /**

1
tests/Models/StockBillMapperTest.php
View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Billing\tests\Models; namespace Modules\Billing\tests\Models;
use Modules\Billing\Models\StockBillMapper; use Modules\Billing\Models\StockBillMapper;
use phpOMS\Utils\TestUtils;
/** /**
* @testdox Modules\Billing\tests\Models\StockBillMapperTest: App database mapper * @testdox Modules\Billing\tests\Models\StockBillMapperTest: App database mapper