Jingga/oms-Billing
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Billing.git synced 2026-02-16 08:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-10-25 20:06:48 +02:00
parent b3006024c3
commit 0506ae8415
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Models/Bill.php
View File

@ -604,21 +604,22 @@ class Bill implements \JsonSerializable
/** /**
* Get media file by type * Get media file by type
* *
* @param string $type Media type * @param null|int $type Media type
* *
* @return Media * @return array
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function getMediaByType(string $type) : Media public function getMediaByType(int $type = null) : array
{ {
foreach ($this->media as $media) { $files = [];
if ($media->type === $type) { foreach ($this->media as $file) {
return $media; if ($file->type === $type) {
$files[] = $file;
} }
} }
return new NullMedia(); return $files;
} }
/** /**

13
tests/Models/BillTest.php
View File

@ -18,6 +18,7 @@ use Modules\Billing\Models\Bill;
use Modules\Billing\Models\BillElement; use Modules\Billing\Models\BillElement;
use Modules\Billing\Models\BillStatus; use Modules\Billing\Models\BillStatus;
use Modules\Billing\Models\BillType; use Modules\Billing\Models\BillType;
use Modules\Media\Models\Media;
use phpOMS\Localization\ISO4217CharEnum; use phpOMS\Localization\ISO4217CharEnum;
/** /**
@ -53,6 +54,7 @@ final class BillTest extends \PHPUnit\Framework\TestCase
self::assertEquals(null, $this->bill->supplier); self::assertEquals(null, $this->bill->supplier);
self::assertEquals([], $this->bill->getVouchers()); self::assertEquals([], $this->bill->getVouchers());
self::assertEquals([], $this->bill->getTrackings()); self::assertEquals([], $this->bill->getTrackings());
self::assertEquals([], $this->bill->getMediaByType(0));
self::assertEquals('', $this->bill->shipTo); self::assertEquals('', $this->bill->shipTo);
self::assertEquals('', $this->bill->shipFAO); self::assertEquals('', $this->bill->shipFAO);
@ -121,6 +123,17 @@ final class BillTest extends \PHPUnit\Framework\TestCase
self::assertEquals(ISO4217CharEnum::_USD, $this->bill->getCurrency()); self::assertEquals(ISO4217CharEnum::_USD, $this->bill->getCurrency());
} }
/**
* @covers Modules\Billing\Models\Bill
* @group module
*/
public function testMediaInputOutput() : void
{
$this->bill->addMedia($temp = new Media());
self::assertCount(1, $this->bill->getMedia());
self::assertEquals([$temp], $this->bill->getMediaByType());
}
/** /**
* @covers Modules\Billing\Models\Bill * @covers Modules\Billing\Models\Bill
* @group module * @group module