From 015dbe23d9bc336f426bbd473bf163eeafc0c310 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Wed, 30 Aug 2023 12:08:09 +0000
Subject: [PATCH] autofixes

---
 Controller/ApiAttributeController.php |  1 -
 Controller/ApiBillController.php      | 10 +++++-----
 Controller/ApiBillTypeController.php  |  8 ++++----
 Controller/ApiPriceController.php     |  6 ++----
 Controller/ApiTaxController.php       |  6 +++---
 Models/Bill.php                       |  1 -
 6 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/Controller/ApiAttributeController.php b/Controller/ApiAttributeController.php
index e1bac43..c2f8536 100755
--- a/Controller/ApiAttributeController.php
+++ b/Controller/ApiAttributeController.php
@@ -446,7 +446,6 @@ final class ApiAttributeController extends Controller
     public function apiBillAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
     {
         return;
-
         // @todo: I don't think values can be deleted? Only Attributes
         // However, It should be possible to remove UNUSED default values
         // either here or other function?
diff --git a/Controller/ApiBillController.php b/Controller/ApiBillController.php
index 403fce0..dde98b7 100755
--- a/Controller/ApiBillController.php
+++ b/Controller/ApiBillController.php
@@ -112,8 +112,8 @@ final class ApiBillController extends Controller
     /**
      * Method to create a bill from request.
      *
-     * @param RequestAbstract  $request  Request
-     * @param Bill             $old      Bill
+     * @param RequestAbstract $request Request
+     * @param Bill            $old     Bill
      *
      * @return Bill
      *
@@ -1214,8 +1214,8 @@ final class ApiBillController extends Controller
     /**
      * Method to create a bill from request.
      *
-     * @param RequestAbstract  $request  Request
-     * @param Bill             $new Bill
+     * @param RequestAbstract $request Request
+     * @param Bill            $new     Bill
      *
      * @return Bill
      *
@@ -1286,7 +1286,7 @@ final class ApiBillController extends Controller
     /**
      * Method to update BillElement from request.
      *
-     * @param RequestAbstract  $request Request
+     * @param RequestAbstract $request Request
      * @param BillElement     $new     Model to modify
      *
      * @return BillElement
diff --git a/Controller/ApiBillTypeController.php b/Controller/ApiBillTypeController.php
index a69d845..9592a7a 100755
--- a/Controller/ApiBillTypeController.php
+++ b/Controller/ApiBillTypeController.php
@@ -215,8 +215,8 @@ final class ApiBillTypeController extends Controller
     /**
      * Method to update BillType from request.
      *
-     * @param RequestAbstract  $request Request
-     * @param BillType     $new     Model to modify
+     * @param RequestAbstract $request Request
+     * @param BillType        $new     Model to modify
      *
      * @return BillType
      *
@@ -338,8 +338,8 @@ final class ApiBillTypeController extends Controller
     /**
      * Method to update BillTypeL11n from request.
      *
-     * @param RequestAbstract  $request Request
-     * @param BaseStringL11n     $new     Model to modify
+     * @param RequestAbstract $request Request
+     * @param BaseStringL11n  $new     Model to modify
      *
      * @return BaseStringL11n
      *
diff --git a/Controller/ApiPriceController.php b/Controller/ApiPriceController.php
index 2a47d24..c0d4331 100755
--- a/Controller/ApiPriceController.php
+++ b/Controller/ApiPriceController.php
@@ -29,10 +29,8 @@ use Modules\SupplierManagement\Models\NullSupplier;
 use Modules\SupplierManagement\Models\SupplierMapper;
 use phpOMS\Localization\ISO4217CharEnum;
 use phpOMS\Message\Http\RequestStatusCode;
-use phpOMS\Message\NotificationLevel;
 use phpOMS\Message\RequestAbstract;
 use phpOMS\Message\ResponseAbstract;
-use phpOMS\Model\Message\FormValidation;
 use phpOMS\Stdlib\Base\FloatInt;
 use phpOMS\System\MimeType;
 
@@ -348,8 +346,8 @@ final class ApiPriceController extends Controller
     /**
      * Method to update Price from request.
      *
-     * @param RequestAbstract  $request Request
-     * @param Price     $new     Model to modify
+     * @param RequestAbstract $request Request
+     * @param Price           $new     Model to modify
      *
      * @return Price
      *
diff --git a/Controller/ApiTaxController.php b/Controller/ApiTaxController.php
index c8b7df7..40120fc 100755
--- a/Controller/ApiTaxController.php
+++ b/Controller/ApiTaxController.php
@@ -296,7 +296,7 @@ final class ApiTaxController extends Controller
 
             $old = \reset($old);
 
-            $new = clone $old;
+            $new          = clone $old;
             $new->taxCode = $combination['tax_code'];
 
             $this->updateModel($request->header->account, $old, $new, TaxCombinationMapper::class, 'tax_combination', $request->getOrigin());
@@ -327,8 +327,8 @@ final class ApiTaxController extends Controller
     /**
      * Method to update TaxCombination from request.
      *
-     * @param RequestAbstract  $request Request
-     * @param TaxCombination   $new     Model to modify
+     * @param RequestAbstract $request Request
+     * @param TaxCombination  $new     Model to modify
      *
      * @return TaxCombination
      *
diff --git a/Models/Bill.php b/Models/Bill.php
index a9d3409..513a7a4 100755
--- a/Models/Bill.php
+++ b/Models/Bill.php
@@ -17,7 +17,6 @@ namespace Modules\Billing\Models;
 use Modules\Admin\Models\Account;
 use Modules\Admin\Models\NullAccount;
 use Modules\ClientManagement\Models\Client;
-use Modules\Editor\Models\EditorDoc;
 use Modules\Media\Models\Collection;
 use Modules\SupplierManagement\Models\Supplier;
 use phpOMS\Localization\ISO4217CharEnum;