diff --git a/tests/Controller/ApiControllerTest.php b/tests/Controller/ApiControllerTest.php index d9271ea..86f8a69 100755 --- a/tests/Controller/ApiControllerTest.php +++ b/tests/Controller/ApiControllerTest.php @@ -118,6 +118,7 @@ class ApiControllerTest extends \PHPUnit\Framework\TestCase $this->module->apiLogUpdate(1, ['id' => 2, 'test' => true], ['id' => 1, 'test' => true], 1, 2, 'Auditor', 'abc', 'def'); $logs = AuditMapper::getAll(); + $found = false; foreach($logs as $log) { if ($log->getId() > 0 && $log->getType() === 1 @@ -128,12 +129,22 @@ class ApiControllerTest extends \PHPUnit\Framework\TestCase && $log->getOld() === \json_encode(['id' => 2, 'test' => true], \JSON_PRETTY_PRINT) && $log->getNew() === \json_encode(['id' => 1, 'test' => true], \JSON_PRETTY_PRINT) ) { - self::assertTrue(true); - return; + $found = true; + break; } } - self::assertTrue(false); + self::assertTrue($found); + } + + public function testLogUpdateWithoutChange() : void + { + $logs = AuditMapper::getAll(); + $this->module->apiLogUpdate(1, ['id' => 2, 'test' => true], ['id' => 2, 'test' => true], 1, 2, 'Auditor', 'abc', 'def'); + $logs2 = AuditMapper::getAll(); + + self::assertGreaterThan(0, \count($logs)); + self::assertEquals(\count($logs), \count($logs2)); } /** diff --git a/tests/Models/AuditTest.php b/tests/Models/AuditTest.php index d9d7a5f..087a71c 100755 --- a/tests/Models/AuditTest.php +++ b/tests/Models/AuditTest.php @@ -40,6 +40,7 @@ class AuditTest extends \PHPUnit\Framework\TestCase self::assertNull($audit->getContent()); self::assertNull($audit->getOld()); self::assertNull($audit->getNew()); + self::assertEquals(0, $audit->getIp()); self::assertEquals(0, $audit->getCreatedBy()->getId()); self::assertInstanceOf('\DateTimeImmutable', $audit->getCreatedAt()); } @@ -57,7 +58,8 @@ class AuditTest extends \PHPUnit\Framework\TestCase 1, 2, '3', 'test', - 'content' + 'content', + \ip2long('127.0.0.1') ); self::assertEquals(1, $audit->getType()); @@ -67,6 +69,7 @@ class AuditTest extends \PHPUnit\Framework\TestCase self::assertEquals('content', $audit->getContent()); self::assertEquals('old', $audit->getOld()); self::assertEquals('new', $audit->getNew()); + self::assertEquals(\ip2long('127.0.0.1'), $audit->getIp()); self::assertEquals(0, $audit->getCreatedBy()->getId()); } }