Jingga/oms-Auditor
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Auditor.git synced 2026-01-26 20:28:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove some getter/setter

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-11-24 17:31:19 +01:00
parent 4862346d3f
commit 112e06e898
4 changed files with 9 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Models/Audit.php
View File

@ -101,7 +101,7 @@ class Audit
* @var Account
* @since 1.0.0
*/
private Account $createdBy;
public Account $createdBy;
/**
* Created at.
@ -109,7 +109,7 @@ class Audit
* @var \DateTimeImmutable
* @since 1.0.0
*/
private \DateTimeImmutable $createdAt;
public \DateTimeImmutable $createdAt;
/**
* Ip of creator.
@ -255,30 +255,6 @@ class Audit
return $this->new;
}
/**
* Get created by.
*
* @return Account|int
*
* @since 1.0.0
*/
public function getCreatedBy()
{
return $this->createdBy;
}
/**
* Get created at.
*
* @return \DateTimeImmutable
*
* @since 1.0.0
*/
public function getCreatedAt() : \DateTimeImmutable
{
return $this->createdAt;
}
/**
* Get ip.
*

4
Theme/Backend/audit-list.tpl.php
View File

@ -65,9 +65,9 @@ echo $this->getData('nav')->render(); ?>
<td><?= $this->printHtml($audit->getOld()); ?>
<td><?= $this->printHtml($audit->getNew()); ?>
<td><?= $this->printHtml($audit->getContent()); ?>
<td><?= $this->printHtml($audit->getCreatedBy()->getName()); ?>
<td><?= $this->printHtml($audit->createdBy->login); ?>
<td><?= $this->printHtml($audit->getRef()); ?>
<td><?= $audit->getCreatedAt()->format('Y-m-d H:i'); ?>
<td><?= $audit->createdAt->format('Y-m-d H:i'); ?>
<?php endforeach; ?>
<?php if ($count === 0) : ?>
<tr><td colspan="10" class="empty"><?= $this->getHtml('Empty', '0', '0'); ?>

4
Theme/Backend/audit-single.tpl.php
View File

@ -51,10 +51,10 @@ echo $this->getData('nav')->render();
<tr>
<th>Created By
<td><?= $audit->getCreatedBy()->getName1(); ?>
<td><?= $audit->createdBy->name1; ?>
<tr>
<th>Created At
<td><?= $this->getDateTime($audit->getCreatedAt(), 'long'); ?>
<td><?= $this->getDateTime($audit->createdAt, 'long'); ?>
<tr>
<th>Module
<td><?= $audit->getModule(); ?>

6
tests/Models/AuditTest.php
View File

@ -41,8 +41,8 @@ class AuditTest extends \PHPUnit\Framework\TestCase
self::assertNull($audit->getOld());
self::assertNull($audit->getNew());
self::assertEquals(0, $audit->getIp());
self::assertEquals(0, $audit->getCreatedBy()->getId());
self::assertInstanceOf('\DateTimeImmutable', $audit->getCreatedAt());
self::assertEquals(0, $audit->createdBy->getId());
self::assertInstanceOf('\DateTimeImmutable', $audit->createdAt);
}
/**
@ -70,6 +70,6 @@ class AuditTest extends \PHPUnit\Framework\TestCase
self::assertEquals('old', $audit->getOld());
self::assertEquals('new', $audit->getNew());
self::assertEquals(\ip2long('127.0.0.1'), $audit->getIp());
self::assertEquals(0, $audit->getCreatedBy()->getId());
self::assertEquals(0, $audit->createdBy->getId());
}
}