From 0b6d011eebe1be1e8395b8ce524270ecb110c262 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Thu, 21 Oct 2021 22:16:05 +0200
Subject: [PATCH] more tests and make classes final

---
 Models/Audit.php                       |  2 +-
 Models/NullAudit.php                   | 12 ++++++++
 tests/Controller/ApiControllerTest.php |  2 +-
 tests/Models/NullAudit.php             | 42 ++++++++++++++++++++++++++
 tests/Models/NullAuditTest.php         | 10 ++++++
 5 files changed, 66 insertions(+), 2 deletions(-)
 create mode 100644 tests/Models/NullAudit.php

diff --git a/Models/Audit.php b/Models/Audit.php
index bf98540..66f2702 100755
--- a/Models/Audit.php
+++ b/Models/Audit.php
@@ -33,7 +33,7 @@ class Audit
      * @var int
      * @since 1.0.0
      */
-    private int $id = 0;
+    protected int $id = 0;
 
     /**
      * Audit type.
diff --git a/Models/NullAudit.php b/Models/NullAudit.php
index a764b20..fba83f5 100755
--- a/Models/NullAudit.php
+++ b/Models/NullAudit.php
@@ -24,4 +24,16 @@ namespace Modules\Auditor\Models;
  */
 final class NullAudit extends Audit
 {
+	/**
+     * Constructor
+     *
+     * @param int $id Model id
+     *
+     * @since 1.0.0
+     */
+    public function __construct(int $id = 0)
+    {
+        $this->id = $id;
+        parent::__construct();
+    }
 }
diff --git a/tests/Controller/ApiControllerTest.php b/tests/Controller/ApiControllerTest.php
index 7efe8f1..fc8395f 100755
--- a/tests/Controller/ApiControllerTest.php
+++ b/tests/Controller/ApiControllerTest.php
@@ -12,7 +12,7 @@
  */
 declare(strict_types=1);
 
-namespace Modules\Audit\tests\Controller;
+namespace Modules\Auditor\tests\Controller;
 
 use Model\CoreSettings;
 use Modules\Admin\Models\AccountPermission;
diff --git a/tests/Models/NullAudit.php b/tests/Models/NullAudit.php
new file mode 100644
index 0000000..d9afee9
--- /dev/null
+++ b/tests/Models/NullAudit.php
@@ -0,0 +1,42 @@
+<?php
+/**
+ * Orange Management
+ *
+ * PHP Version 8.0
+ *
+ * @package   tests
+ * @copyright Dennis Eichhorn
+ * @license   OMS License 1.0
+ * @version   1.0.0
+ * @link      https://orange-management.org
+ */
+declare(strict_types=1);
+
+namespace Modules\Auditor\tests\Models;
+
+use Modules\Auditor\Models\NullAudit;
+
+/**
+ * @internal
+ */
+final class Null extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @covers Modules\Auditor\Models\NullAudit
+     * @group framework
+     */
+    public function testNull() : void
+    {
+        self::assertInstanceOf('\Modules\Auditor\Models\Audit', new NullAudit());
+    }
+
+    /**
+     * @covers Modules\Auditor\Models\NullAudit
+     * @group framework
+     */
+    public function testId() : void
+    {
+        $null = new NullAudit(2);
+        self::assertEquals(2, $null->getId());
+    }
+}
diff --git a/tests/Models/NullAuditTest.php b/tests/Models/NullAuditTest.php
index 7be46b8..d3032aa 100755
--- a/tests/Models/NullAuditTest.php
+++ b/tests/Models/NullAuditTest.php
@@ -29,4 +29,14 @@ final class NullAuditTest extends \PHPUnit\Framework\TestCase
     {
         self::assertInstanceOf('\Modules\Auditor\Models\Audit', new NullAudit());
     }
+
+    /**
+     * @covers Modules\Auditor\Models\NullAudit
+     * @group framework
+     */
+    public function testId() : void
+    {
+        $null = new NullAudit(2);
+        self::assertEquals(2, $null->getId());
+    }
 }