Jingga/oms-Attribute
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Attribute.git synced 2026-01-11 16:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2024-03-17 03:57:41 +00:00
parent 4667711fcb
commit 67042190ac
4 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Models/AttributeValue.php
View File

@ -167,7 +167,9 @@ class AttributeValue implements \JsonSerializable
} elseif ($datatype === AttributeValueType::_FLOAT) { } elseif ($datatype === AttributeValueType::_FLOAT) {
$this->valueDec = (float) $value; $this->valueDec = (float) $value;
} elseif ($datatype === AttributeValueType::_DATETIME) { } elseif ($datatype === AttributeValueType::_DATETIME) {
$this->valueDat = new \DateTime((string) $value); $this->valueDat = $value instanceof \DateTime
? $value
: new \DateTime((string) $value);
} }
} }

2
tests/Models/AttributeHolderTraitTest.php
View File

@ -36,8 +36,6 @@ final class AttributeHolderTraitTestTest extends \PHPUnit\Framework\TestCase
protected function setUp() : void protected function setUp() : void
{ {
$this->holder = new class() { $this->holder = new class() {
public $attributes = [];
use AttributeHolderTrait; use AttributeHolderTrait;
}; };

4
tests/Models/AttributeTypeTest.php
View File

@ -99,6 +99,8 @@ final class AttributeTypeTest extends \PHPUnit\Framework\TestCase
'validationPattern' => '', 'validationPattern' => '',
'custom' => false, 'custom' => false,
'isRequired' => false, 'isRequired' => false,
'isInternal' => false,
'repeatable' => false,
], ],
$type->toArray() $type->toArray()
); );
@ -115,6 +117,8 @@ final class AttributeTypeTest extends \PHPUnit\Framework\TestCase
'validationPattern' => '', 'validationPattern' => '',
'custom' => false, 'custom' => false,
'isRequired' => false, 'isRequired' => false,
'isInternal' => false,
'repeatable' => false,
], ],
$type->jsonSerialize() $type->jsonSerialize()
); );

18
tests/Models/AttributeValueTest.php
View File

@ -78,10 +78,11 @@ final class AttributeValueTest extends \PHPUnit\Framework\TestCase
self::assertEquals( self::assertEquals(
[ [
'id' => 0, 'id' => 0,
'name' => '', 'valueInt' => null,
'validationPattern' => '', 'valueStr' => null,
'custom' => false, 'valueDec' => null,
'isRequired' => false, 'valueDat' => null,
'isDefault' => false,
], ],
$value->toArray() $value->toArray()
); );
@ -93,10 +94,11 @@ final class AttributeValueTest extends \PHPUnit\Framework\TestCase
self::assertEquals( self::assertEquals(
[ [
'id' => 0, 'id' => 0,
'name' => '', 'valueInt' => null,
'validationPattern' => '', 'valueStr' => null,
'custom' => false, 'valueDec' => null,
'isRequired' => false, 'valueDat' => null,
'isDefault' => false,
], ],
$value->jsonSerialize() $value->jsonSerialize()
); );