Jingga/oms-Admin
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Admin.git synced 2026-02-05 07:58:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Dennis Eichhorn 2024-04-25 22:53:57 +00:00
parent 378473fb38
commit cf4398ad8a
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Controller/ApiController.php
View File

@ -905,6 +905,25 @@ final class ApiController extends Controller
return [];
}
/**
* Validate password update request
*
* @param RequestAbstract $request Request
*
* @return array<string, bool>
*
* @since 1.0.0
*/
private function validateLocalizationUpdate(RequestAbstract $request) : array
{
$val = [];
if (($val['id'] = !$request->hasData('id'))) {
return $val;
}
return [];
}
/**
* Api method for modifying account localization
*
@ -920,6 +939,13 @@ final class ApiController extends Controller
*/
public function apiSettingsAccountLocalizationSet(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void
{
if (!empty($val = $this->validateLocalizationUpdate($request))) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidUpdateResponse($request, $response, $val);
return;
}
/** @var \Modules\Admin\Models\Account $account */
$account = AccountMapper::get()
->with('l11n')
@ -929,7 +955,7 @@ final class ApiController extends Controller
$requestAccount = $request->header->account;
if ($account->id !== 0
&& $requestAccount !== $account->id
&& !$this->app->accountManager->get($account->id)->hasPermission(
&& !$this->app->accountManager->get($requestAccount)->hasPermission(
PermissionType::MODIFY,
$this->app->unitId,
$this->app->appId,

2
tests/Controller/Api/ApiControllerSettingsTrait.php
View File

@ -118,7 +118,7 @@ trait ApiControllerSettingsTrait
$response = new HttpResponse();
$request = new HttpRequest();
$request->header->account = 2;
$request->header->account = 3;
$request->setData('id', 1);
$this->module->apiSettingsAccountLocalizationSet($request, $response);