Jingga/oms-Admin
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Admin.git synced 2026-02-15 03:58:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

static analysis fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-06-06 22:09:26 +02:00
parent d04260f4c6
commit c88b01023a
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Controller/ApiController.php
View File

@ -832,7 +832,7 @@ final class ApiController extends Controller
$updateFilesJson = Rest::request($request)->getJsonData(); $updateFilesJson = Rest::request($request)->getJsonData();
/** @var array<string, array<string, array>> */ /** @var array<string, array<string, mixed>> */
$toUpdate = []; $toUpdate = [];
foreach ($updateFilesJson as $file) { foreach ($updateFilesJson as $file) {
@ -853,9 +853,9 @@ final class ApiController extends Controller
$remoteVersion = \substr($file[1], 0, -5); $remoteVersion = \substr($file[1], 0, -5);
if (Version::compare($currentVersion, $remoteVersion) < 0) { if (Version::compare($currentVersion, $remoteVersion) < 0) {
$toUpdate[$name][$remoteVersion] = $file; $toUpdate[$name[0]][$remoteVersion] = $file;
\uksort($toUpdate[$name], [Version::class, 'compare']); \uksort($toUpdate[$name[0]], [Version::class, 'compare']);
} }
} }
@ -908,7 +908,12 @@ final class ApiController extends Controller
private function runUpdate(string $updateFile) : void private function runUpdate(string $updateFile) : void
{ {
$package = \json_decode(\file_get_contents($updateFile), true); $updateContent = \file_get_contents($updateFile);
if ($updateContent === false) {
return;
}
$package = \json_decode($updateContent, true);
$updatePath = \dirname($updateFile); $updatePath = \dirname($updateFile);
$subPath = $package['type'] === 'Modules/' ? $package['name'] : ''; $subPath = $package['type'] === 'Modules/' ? $package['name'] : '';