Jingga/oms-Admin
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Admin.git synced 2026-01-28 20:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix todos/move to todo list

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-11-26 20:50:18 +01:00
parent 346e100350
commit c78584dbb5
7 changed files with 12 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Controller/ApiController.php
View File

@ -68,12 +68,6 @@ use phpOMS\Version\Version;
* @license OMS License 1.0
* @link https://orange-management.org
* @since 1.0.0
*
* @todo Orange-Management/Modules#172
* Add user & group settings
*
* @todo Orange-Management/Modules#193
* Implement online database and downloading api for modules and updates
*/
final class ApiController extends Controller
{

1
Controller/Controller.php
View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Admin\Controller;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\WebInterface;
/**
* Admin controller class.

4
Models/AccountMapper.php
View File

@ -119,9 +119,6 @@ final class AccountMapper extends DataMapperAbstract
*
* @return Account
*
* @todo Orange-Management/oms-Admin#11
* [AccountMapper] Create test for getWithPermission()
*
* @since 1.0.0
*/
public static function getWithPermissions(int $id) : Account
@ -187,7 +184,6 @@ final class AccountMapper extends DataMapperAbstract
$result = $result[0];
// @todo: implement account tries
if ($result['account_tries'] <= 0) {
return LoginReturnType::WRONG_INPUT_EXCEEDED;
}

15
Theme/Backend/accounts-single.tpl.php
View File

@ -19,21 +19,6 @@ use phpOMS\Account\PermissionType;
use phpOMS\Message\Http\HttpHeader;
use phpOMS\Uri\UriFactory;
/**
* @todo Orange-Management/Modules#122
* Add group account removal
* In front of every account there should be a red x which allows to remove an account from the group.
*
* @todo Orange-Management/Modules#127
* Add account group removal
* Add red x in front of every group which removes the group for this account.
*
* @todo Orange-Management/Modules#126
* Add account log tab
* Add auditing log tab to accounts for whenever something changes for an account.
* This tab should show everything this user is doing and all places where he is mentioned.
*/
/**
* @var \phpOMS\Views\View $this
*/

26
Theme/Backend/groups-single.tpl.php
View File

@ -18,32 +18,6 @@ use phpOMS\Account\PermissionType;
use phpOMS\Message\Http\HttpHeader;
use phpOMS\Uri\UriFactory;
/**
* @todo Orange-Management/Modules#122
* Add group account removal
* In front of every account there should be a red x which allows to remove an account from the group.
*
* @todo Orange-Management/Modules#127
* Add account group removal
* Add red x in front of every group which removes the group for this account.
*
* @todo Orange-Management/Modules#124
* Add group permission removal
* Add a red x in front of every permission which removes the permission from the group.
*
* @todo Orange-Management/Modules#123
* Add group permission adjustment
* In front of every permission there should be a cogs sign for modifying permissions.
* Clicking on it will put the info into the form below and change the button from add to update.
* At the same time there should be a clear button which allows to clear all these info and show the add button again.
* Alternatively the modification could be done inline in the permission list.
*
* @todo Orange-Management/Modules#125
* Add group log tab for audits
* A new tab should be added where all changes can be audited if required.
* This tab should also show all the places where the group is mentioned.
*/
/**
* @var \phpOMS\Views\View $this
*/

12
Theme/Backend/modules-list.tpl.php
View File

@ -38,20 +38,20 @@ $isntalled = $this->getData('isntalled') ?? [];
<tbody>
<?php $count = 0;
foreach ($modules as $key => $module) : ++$count;
$url = UriFactory::build('{/prefix}admin/module/settings?{?}&id=' . $module['name']['internal']);
$url = UriFactory::build('{/prefix}admin/module/settings?{?}&id=' . $module->getInternalName());
if (isset($active[$module['name']['internal']])) {
if (isset($active[$module->getInternalName()])) {
$status = ModuleStatus::ACTIVE;
} elseif (isset($installed[$module['name']['internal']])) {
} elseif (isset($installed[$module->getInternalName()])) {
$status = ModuleStatus::INACTIVE;
} else {
$status = ModuleStatus::AVAILABLE;
}
?>
<tr tabindex="0" data-href="<?= $url; ?>">
<td data-label="<?= $this->getHtml('ID', '0', '0'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module['name']['id']); ?></a>
<td data-label="<?= $this->getHtml('Name'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module['name']['external']); ?></a>
<td data-label="<?= $this->getHtml('Version'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module['version']); ?></a>
<td data-label="<?= $this->getHtml('ID', '0', '0'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module->getId()); ?></a>
<td data-label="<?= $this->getHtml('Name'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module->getExternalName()); ?></a>
<td data-label="<?= $this->getHtml('Version'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($module->getVersion()); ?></a>
<td data-label="<?= $this->getHtml('Status'); ?>">
<span class="tag">
<a href="<?= $url; ?>">

12
Theme/Backend/modules-single.tpl.php
View File

@ -47,26 +47,26 @@ if ($nav !== null) {
<div class="row">
<div class="col-xs-12 col-md-4">
<div class="portlet">
<div class="portlet-head"><?= $this->printHtml($modules[$id]['name']['external']); ?></div>
<div class="portlet-head"><?= $this->printHtml($modules[$id]->getExternalName()); ?></div>
<div class="portlet-body">
<table class="list wf-100">
<tbody>
<tr>
<td><?= $this->getHtml('Name'); ?>
<td><?= $this->printHtml($modules[$id]['name']['external']); ?>
<td><?= $this->printHtml($modules[$id]->getExternalName()); ?>
<tr>
<td><?= $this->getHtml('Version'); ?>
<td><?= $this->printHtml($modules[$id]['version']); ?>
<td><?= $this->printHtml($modules[$id]->getVersion()); ?>
<tr>
<td><?= $this->getHtml('CreatedBy'); ?>
<td><?= $this->printHtml($modules[$id]['creator']['name']); ?>
<td><?= $this->printHtml($modules[$id]->get()['creator']['name']); ?>
<tr>
<td><?= $this->getHtml('Website'); ?>
<td><?= $this->printHtml($modules[$id]['creator']['website']); ?>
<td><?= $this->printHtml($modules[$id]->get()['creator']['website']); ?>
<tr>
<td><?= $this->getHtml('Description'); ?>
<td><?= $this->printHtml($modules[$id]['description']); ?>
<td><?= $this->printHtml($modules[$id]->get()['description']); ?>
</table>
</div>
<div class="portlet-foot">