From a38d24e8377df000910f9fd472d60bc9cc81c100 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Thu, 10 Sep 2020 20:18:46 +0200
Subject: [PATCH] implement immutable datetime

---
 Models/AccountMapper.php    | 2 +-
 Models/Group.php            | 6 +++---
 Models/GroupMapper.php      | 2 +-
 Models/Module.php           | 6 +++---
 tests/Models/ModuleTest.php | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Models/AccountMapper.php b/Models/AccountMapper.php
index c564c47..4589ea2 100755
--- a/Models/AccountMapper.php
+++ b/Models/AccountMapper.php
@@ -49,7 +49,7 @@ final class AccountMapper extends DataMapperAbstract
         'account_tries'        => ['name' => 'account_tries',        'type' => 'int',      'internal' => 'tries'],
         'account_lactive'      => ['name' => 'account_lactive',      'type' => 'DateTime', 'internal' => 'lastActive'],
         'account_localization' => ['name' => 'account_localization', 'type' => 'int',      'internal' => 'localization'],
-        'account_created_at'   => ['name' => 'account_created_at',   'type' => 'DateTime', 'internal' => 'createdAt', 'readonly' => true],
+        'account_created_at'   => ['name' => 'account_created_at',   'type' => 'DateTimeImmutable', 'internal' => 'createdAt', 'readonly' => true],
     ];
 
     /**
diff --git a/Models/Group.php b/Models/Group.php
index 73f8196..e248f49 100755
--- a/Models/Group.php
+++ b/Models/Group.php
@@ -30,7 +30,7 @@ class Group extends \phpOMS\Account\Group
      * @var \DateTime
      * @since 1.0.0
      */
-    protected \DateTime $createdAt;
+    protected \DateTimeImmutable $createdAt;
 
     /**
      * Created by.
@@ -66,7 +66,7 @@ class Group extends \phpOMS\Account\Group
     public function __construct(string $name = '')
     {
         $this->createdBy = new NullAccount();
-        $this->createdAt = new \DateTime('now');
+        $this->createdAt = new \DateTimeImmutable('now');
         $this->setName($name);
     }
 
@@ -77,7 +77,7 @@ class Group extends \phpOMS\Account\Group
      *
      * @since 1.0.0
      */
-    public function getCreatedAt() : \DateTime
+    public function getCreatedAt() : \DateTimeInterface
     {
         return $this->createdAt;
     }
diff --git a/Models/GroupMapper.php b/Models/GroupMapper.php
index 52cc3aa..00e6fd2 100755
--- a/Models/GroupMapper.php
+++ b/Models/GroupMapper.php
@@ -39,7 +39,7 @@ final class GroupMapper extends DataMapperAbstract
         'group_status'   => ['name' => 'group_status',   'type' => 'int',      'internal' => 'status'],
         'group_desc'     => ['name' => 'group_desc',     'type' => 'string',   'internal' => 'description'],
         'group_desc_raw' => ['name' => 'group_desc_raw', 'type' => 'string',   'internal' => 'descriptionRaw'],
-        'group_created'  => ['name' => 'group_created',  'type' => 'DateTime', 'internal' => 'createdAt', 'readonly' => true],
+        'group_created'  => ['name' => 'group_created',  'type' => 'DateTimeImmutable', 'internal' => 'createdAt', 'readonly' => true],
     ];
 
     /**
diff --git a/Models/Module.php b/Models/Module.php
index 1f4bb51..d9651a2 100755
--- a/Models/Module.php
+++ b/Models/Module.php
@@ -65,7 +65,7 @@ class Module
      * @var \DateTime
      * @since 1.0.0
      */
-    protected \DateTime $createdAt;
+    protected \DateTimeImmutable $createdAt;
 
     /**
      * Constructor.
@@ -74,7 +74,7 @@ class Module
      */
     public function __construct()
     {
-        $this->createdAt = new \DateTime('now');
+        $this->createdAt = new \DateTimeImmutable('now');
     }
 
     /**
@@ -96,7 +96,7 @@ class Module
      *
      * @since 1.0.0
      */
-    public function getCreatedAt() : \DateTime
+    public function getCreatedAt() : \DateTimeInterface
     {
         return $this->createdAt;
     }
diff --git a/tests/Models/ModuleTest.php b/tests/Models/ModuleTest.php
index 17960ed..a64601c 100755
--- a/tests/Models/ModuleTest.php
+++ b/tests/Models/ModuleTest.php
@@ -39,7 +39,7 @@ class ModuleTest extends \PHPUnit\Framework\TestCase
     public function testDefault() : void
     {
         self::assertEquals(0, $this->module->getId());
-        self::assertInstanceOf('\DateTime', $this->module->getCreatedAt());
+        self::assertInstanceOf('\DateTimeImmutable', $this->module->getCreatedAt());
         self::assertEquals('', $this->module->getName());
         self::assertEquals('', $this->module->getDescription());
         self::assertEquals(ModuleStatus::INACTIVE, $this->module->getStatus());