From 2c4fa26fe5a1015a7d1ddbeda4e91b63ff6b8dce Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Mon, 2 Mar 2020 22:49:01 +0100
Subject: [PATCH] php cs and stan fixes

---
 Controller/ApiController.php                    |  3 +--
 .../GroupTagSelectorPopupView.php               |  8 +++++++-
 .../GroupTagSelector/GroupTagSelectorView.php   | 17 +++++++++++++++--
 3 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index 737e15c..c4c354d 100644
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -528,8 +528,7 @@ final class ApiController extends Controller
         );
 
         $this->updateModel($request->getHeader()->getAccount(), $old, $account, function() use($account) : void {
-            $t = $this->app->appSettings->get(null, Settings::LOGIN_TRIES);
-            $account->setLoginTries((int) $this->app->appSettings->get(null, Settings::LOGIN_TRIES));
+            $account->setLoginTries((int) $this->app->appSettings->get(null, (string) Settings::LOGIN_TRIES));
             AccountMapper::update($account);
         }, 'account');
     }
diff --git a/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorPopupView.php b/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorPopupView.php
index 6210d52..f7168b2 100644
--- a/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorPopupView.php
+++ b/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorPopupView.php
@@ -30,7 +30,13 @@ use phpOMS\Views\View;
  */
 class GroupTagSelectorPopupView extends View
 {
-    private $id = '';
+    /**
+     * Dom id
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    private string $id = '';
 
     /**
      * {@inheritdoc}
diff --git a/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorView.php b/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorView.php
index 0efb7f5..c48146b 100644
--- a/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorView.php
+++ b/Theme/Backend/Components/GroupTagSelector/GroupTagSelectorView.php
@@ -30,8 +30,21 @@ use phpOMS\Views\View;
  */
 class GroupTagSelectorView extends View
 {
-    private $id         = '';
-    private $isRequired = false;
+    /**
+     * Dom id
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    private string $id = '';
+
+    /**
+     * Is required?
+     *
+     * @var bool
+     * @since 1.0.0
+     */
+    private bool $isRequired = false;
 
     /**
      * {@inheritdoc}