From ed1cf2413c15ad3e6c4e1987af47998d2662886c Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 7 Feb 2019 00:05:31 +0100 Subject: [PATCH] phpcs+phpstan fixes --- Admin/Install/Navigation.php | 2 +- Controller/BackendController.php | 20 ++++++++++---------- Models/AccountAbstract.php | 2 +- Models/CostCenter.php | 2 +- Models/CostObject.php | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Admin/Install/Navigation.php b/Admin/Install/Navigation.php index 4a169e1..9c51915 100644 --- a/Admin/Install/Navigation.php +++ b/Admin/Install/Navigation.php @@ -36,7 +36,7 @@ class Navigation * * @since 1.0.0 */ - public static function install(string $path = null, DatabasePool $dbPool = null) : void + public static function install(string $path, DatabasePool $dbPool) : void { \Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']); } diff --git a/Controller/BackendController.php b/Controller/BackendController.php index b683918..8af8357 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -40,7 +40,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewEntries(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewEntries(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/entries'); @@ -59,7 +59,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewJournalList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewJournalList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/journal-list'); @@ -78,7 +78,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewStackList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewStackList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/stack-list'); @@ -97,7 +97,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewStackPredefinedList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewStackPredefinedList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/stack-predefined-list'); @@ -116,7 +116,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewStackCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewStackCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/stack-create'); @@ -135,7 +135,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewStackEntries(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewStackEntries(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/stack-entries'); @@ -154,7 +154,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewStackArchiveList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewStackArchiveList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/stack-archive-list'); @@ -173,7 +173,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewGLList(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewGLList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/gl-list'); @@ -192,7 +192,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewGLCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewGLCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/gl-create'); @@ -211,7 +211,7 @@ final class BackendController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewGLProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable + public function viewGLProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface { $view = new View($this->app, $request, $response); $view->setTemplate('/Modules/Accounting/Theme/Backend/gl-profile'); diff --git a/Models/AccountAbstract.php b/Models/AccountAbstract.php index 3b810e3..c6a48fb 100644 --- a/Models/AccountAbstract.php +++ b/Models/AccountAbstract.php @@ -36,7 +36,7 @@ abstract class AccountAbstract /** * Type. * - * @var AccountType + * @var int * @since 1.0.0 */ protected $type = AccountType::IMPERSONAL; diff --git a/Models/CostCenter.php b/Models/CostCenter.php index 29e30ed..743d2a0 100644 --- a/Models/CostCenter.php +++ b/Models/CostCenter.php @@ -145,4 +145,4 @@ class CostCenter { return $this->description; } -} \ No newline at end of file +} diff --git a/Models/CostObject.php b/Models/CostObject.php index a5207e8..bbdaf72 100644 --- a/Models/CostObject.php +++ b/Models/CostObject.php @@ -145,4 +145,4 @@ class CostObject { return $this->description; } -} \ No newline at end of file +}