From 4530d6eb975df4a34b37900852f678e70115524b Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Wed, 24 Apr 2024 03:20:46 +0000
Subject: [PATCH] more tests and some fixes

---
 .github/workflows/main.yml |  9 +++++++--
 Controller.js              | 12 +++++++-----
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index e1e05f8..278096d 100755
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -13,10 +13,15 @@ on:
     - cron: '0 0 1,15 * *'
 
 jobs:
-  general_module_workflow:
+  general_module_workflow_php:
     uses: Karaka-Management/Karaka/.github/workflows/php_template.yml@develop
     secrets:
       GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       GH_PAT: ${{ secrets.GH_PAT }}
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-
+  general_module_workflow_js:
+    uses: Karaka-Management/Karaka/.github/workflows/js_template.yml@develop
+    secrets:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      GH_PAT: ${{ secrets.GH_PAT }}
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
\ No newline at end of file
diff --git a/Controller.js b/Controller.js
index 705e20f..482ca64 100644
--- a/Controller.js
+++ b/Controller.js
@@ -3,6 +3,7 @@ import { Autoloader } from '../../jsOMS/Autoloader.js';
 
 Autoloader.defineNamespace('omsApp.Modules');
 
+/* global omsApp */
 omsApp.Modules.Accounting = class {
     /**
      * @constructor
@@ -45,11 +46,11 @@ omsApp.Modules.Accounting = class {
             return;
         }
 
-        const self = this;
         const data = JSON.parse(chart.getAttribute('data-chart'));
 
+        /* global Chart */
+        // eslint-disable-next-line no-unused-vars
         const myChart = new Chart(chart.getContext('2d'), data);
-
     };
 
     bindMap (map)
@@ -60,6 +61,7 @@ omsApp.Modules.Accounting = class {
             return;
         }
 
+        /* global OpenLayers */
         const mapObj = new OpenLayers.Map(map.getAttribute('id'), {
             controls: [
                 new OpenLayers.Control.Navigation(
@@ -75,12 +77,12 @@ omsApp.Modules.Accounting = class {
 
         mapObj.addLayer(new OpenLayers.Layer.OSM());
 
-        const fromProjection = new OpenLayers.Projection("EPSG:4326");   // Transform from WGS 1984
-        const toProjection   = new OpenLayers.Projection("EPSG:900913"); // to Spherical Mercator Projection
+        const fromProjection = new OpenLayers.Projection('EPSG:4326');   // Transform from WGS 1984
+        const toProjection   = new OpenLayers.Projection('EPSG:900913'); // to Spherical Mercator Projection
         const position       = new OpenLayers.LonLat(map.getAttribute('data-lon'), map.getAttribute('data-lat')).transform(fromProjection, toProjection);
         const zoom           = 12;
 
-        const markers = new OpenLayers.Layer.Markers("Markers");
+        const markers = new OpenLayers.Layer.Markers('Markers');
         mapObj.addLayer(markers);
 
         markers.addMarker(new OpenLayers.Marker(position));