Jingga/jsOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/jsOMS.git synced 2026-02-14 00:18:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Draft remove implementation

Browse Source
This commit is contained in:
Dennis Eichhorn 2017-10-24 21:08:36 +02:00
parent 14b668f54c
commit d284ff0312
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
UI/ActionManager.js
View File

@ -85,17 +85,31 @@
// if it has selector then a listener for child events must be implemented since these can potentially changed without any knowledge // if it has selector then a listener for child events must be implemented since these can potentially changed without any knowledge
// todo: what if the selector parent is different from "e"? then this doesn't make sense! Maybe this isn't allowed to happen! // todo: what if the selector parent is different from "e"? then this doesn't make sense! Maybe this isn't allowed to happen!
// todo: careful this could cause bugs if there is another component relying on a listener for this dom element. Maybe create actionManager domlistener?
// Maybe just use this listener for ALL action listeners and check if delete, then remove otherwise do current stuff.
// Problem is, the listener doesn't work for the node itself only for children and listening to ALL document nodes might be a bad idea?!?!?!
const observeConfig = {childList: false, attributes: true, subtree: false};
if(hasSelector) { if(hasSelector) {
this.app.eventManager.attach(e.id + 'childList', function(data) { this.app.eventManager.attach(e.id + 'childList', function(data) {
console.log(data);
const length = data.addedNodes.length; const length = data.addedNodes.length;
for(let j = 0; j < length; j++) { for(let j = 0; j < length; j++) {
self.bindListener(data.addedNodes[j], listeners[i]); self.bindListener(data.addedNodes[j], listeners[i]);
} }
});
this.app.uiManager.getDOMObserver().observe(e, {childList: true, subtree: true}); observeConfig.childList = true;
observeConfig.subtree = true;
});
} }
this.app.eventManager.attach(e.id + 'attributes', function(data) {
console.log(data);
});
this.app.uiManager.getDOMObserver().observe(e, observeConfig);
} }
}; };