inspection fixes
Some checks are pending
CodeQL / Analyze (javascript) (push) Waiting to run
CI / general_module_workflow_js (push) Waiting to run

This commit is contained in:
Dennis Eichhorn 2024-05-17 14:15:52 +00:00
parent 61aa586189
commit 94fb96686b
4 changed files with 94 additions and 74 deletions

View File

@ -13,4 +13,4 @@ export const ResponseType = Object.freeze({
BLOB: 'blob',
ARRAYBUFFER: 'arraybuffer',
DEFAULT: ''
});
});

View File

@ -242,7 +242,7 @@ export class Form
? self.forms[document.getElementById(id).getAttribute('data-update-form')].getFormElement()
: (
document.getElementById(id).getAttribute('data-delete-form') !== null
? self.forms[document.getElementById(id).getAttribute('data-delete-form')].getFormElement()
? self.forms[document.getElementById(id).getAttribute('data-delete-form')].getFormElement()
: null
)
);
@ -408,7 +408,7 @@ export class Form
{
jsOMS.preventAll(event);
if (document.querySelector('[data-update-form="' + id + '"') === null) {
if (document.querySelector('[data-update-form="' + id + '"') === null) {
this.formActionSaveInline(self, event, id, elementIndex);
} else {
this.formActionSaveExternal(self, event, id, elementIndex);
@ -600,7 +600,7 @@ export class Form
formActionSaveExternal (self, event, id, elementIndex)
{
const mainForm = document.querySelector('[data-update-form="' + id + '"');
const mainForm = document.querySelector('[data-update-form="' + id + '"');
const externalFormId = id;
id = mainForm.getAttribute('id');

View File

@ -8,7 +8,7 @@
}
],
"require-dev": {
"squizlabs/php_codesniffer": ">=3.7",
"phpcsstandards/php_codesniffer": ">=3.7",
"phpstan/phpstan": ">=0.12.18"
}
}

158
composer.lock generated
View File

@ -4,21 +4,102 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "6f994d7ac9a0187ad572589bd8174666",
"content-hash": "1e66c17ce720238564662eda5e375608",
"packages": [],
"packages-dev": [
{
"name": "phpstan/phpstan",
"version": "1.10.35",
"name": "phpcsstandards/php_codesniffer",
"version": "3.9.2",
"source": {
"type": "git",
"url": "https://github.com/phpstan/phpstan.git",
"reference": "e730e5facb75ffe09dfb229795e8c01a459f26c3"
"url": "https://github.com/PHPCSStandards/PHP_CodeSniffer.git",
"reference": "aac1f6f347a5c5ac6bc98ad395007df00990f480"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/phpstan/phpstan/zipball/e730e5facb75ffe09dfb229795e8c01a459f26c3",
"reference": "e730e5facb75ffe09dfb229795e8c01a459f26c3",
"url": "https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/aac1f6f347a5c5ac6bc98ad395007df00990f480",
"reference": "aac1f6f347a5c5ac6bc98ad395007df00990f480",
"shasum": ""
},
"require": {
"ext-simplexml": "*",
"ext-tokenizer": "*",
"ext-xmlwriter": "*",
"php": ">=5.4.0"
},
"require-dev": {
"phpunit/phpunit": "^4.0 || ^5.0 || ^6.0 || ^7.0 || ^8.0 || ^9.3.4"
},
"bin": [
"bin/phpcbf",
"bin/phpcs"
],
"type": "library",
"extra": {
"branch-alias": {
"dev-master": "3.x-dev"
}
},
"notification-url": "https://packagist.org/downloads/",
"license": [
"BSD-3-Clause"
],
"authors": [
{
"name": "Greg Sherwood",
"role": "Former lead"
},
{
"name": "Juliette Reinders Folmer",
"role": "Current lead"
},
{
"name": "Contributors",
"homepage": "https://github.com/PHPCSStandards/PHP_CodeSniffer/graphs/contributors"
}
],
"description": "PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.",
"homepage": "https://github.com/PHPCSStandards/PHP_CodeSniffer",
"keywords": [
"phpcs",
"standards",
"static analysis"
],
"support": {
"issues": "https://github.com/PHPCSStandards/PHP_CodeSniffer/issues",
"security": "https://github.com/PHPCSStandards/PHP_CodeSniffer/security/policy",
"source": "https://github.com/PHPCSStandards/PHP_CodeSniffer",
"wiki": "https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki"
},
"funding": [
{
"url": "https://github.com/PHPCSStandards",
"type": "github"
},
{
"url": "https://github.com/jrfnl",
"type": "github"
},
{
"url": "https://opencollective.com/php_codesniffer",
"type": "open_collective"
}
],
"abandoned": "squizlabs/php_codesniffer",
"time": "2024-04-23T20:25:34+00:00"
},
{
"name": "phpstan/phpstan",
"version": "1.11.1",
"source": {
"type": "git",
"url": "https://github.com/phpstan/phpstan.git",
"reference": "e524358f930e41a2b4cca1320e3b04fc26b39e0b"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/phpstan/phpstan/zipball/e524358f930e41a2b4cca1320e3b04fc26b39e0b",
"reference": "e524358f930e41a2b4cca1320e3b04fc26b39e0b",
"shasum": ""
},
"require": {
@ -61,70 +142,9 @@
{
"url": "https://github.com/phpstan",
"type": "github"
},
{
"url": "https://tidelift.com/funding/github/packagist/phpstan/phpstan",
"type": "tidelift"
}
],
"time": "2023-09-19T15:27:56+00:00"
},
{
"name": "squizlabs/php_codesniffer",
"version": "3.7.2",
"source": {
"type": "git",
"url": "https://github.com/squizlabs/PHP_CodeSniffer.git",
"reference": "ed8e00df0a83aa96acf703f8c2979ff33341f879"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/squizlabs/PHP_CodeSniffer/zipball/ed8e00df0a83aa96acf703f8c2979ff33341f879",
"reference": "ed8e00df0a83aa96acf703f8c2979ff33341f879",
"shasum": ""
},
"require": {
"ext-simplexml": "*",
"ext-tokenizer": "*",
"ext-xmlwriter": "*",
"php": ">=5.4.0"
},
"require-dev": {
"phpunit/phpunit": "^4.0 || ^5.0 || ^6.0 || ^7.0"
},
"bin": [
"bin/phpcs",
"bin/phpcbf"
],
"type": "library",
"extra": {
"branch-alias": {
"dev-master": "3.x-dev"
}
},
"notification-url": "https://packagist.org/downloads/",
"license": [
"BSD-3-Clause"
],
"authors": [
{
"name": "Greg Sherwood",
"role": "lead"
}
],
"description": "PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.",
"homepage": "https://github.com/squizlabs/PHP_CodeSniffer",
"keywords": [
"phpcs",
"standards",
"static analysis"
],
"support": {
"issues": "https://github.com/squizlabs/PHP_CodeSniffer/issues",
"source": "https://github.com/squizlabs/PHP_CodeSniffer",
"wiki": "https://github.com/squizlabs/PHP_CodeSniffer/wiki"
},
"time": "2023-02-22T23:07:41+00:00"
"time": "2024-05-15T08:00:59+00:00"
}
],
"aliases": [],