From 86d715b4e69ef21ec9e6b9f681ab6af4e5504d02 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Sat, 2 Jul 2016 12:45:08 +0200
Subject: [PATCH] Implementing better response handling

Now multiple responses behaviors are possible for. One for each status
code (200, 404 etc.)
---
 Message/Request/Request.js | 58 +++++++++++++++++++++++++++++---------
 1 file changed, 45 insertions(+), 13 deletions(-)

diff --git a/Message/Request/Request.js b/Message/Request/Request.js
index 8a419f8..99285ed 100644
--- a/Message/Request/Request.js
+++ b/Message/Request/Request.js
@@ -25,10 +25,16 @@
         this.uri           = typeof uri !== 'undefined' ? uri : null;
         this.method        = typeof method !== 'undefined' ? method : jsOMS.Message.Request.RequestMethod.GET;
         this.requestHeader = [];
-        this.success       = null;
+        this.result        = {};
         this.type          = typeof type !== 'undefined' ? type : jsOMS.Message.Response.ResponseType.JSON;
         this.data          = {};
 
+        // todo: create log;
+        this.result[0] = function ()
+        {
+            console.log('invalid response');
+        };
+
         /** global: XMLHttpRequest */
         this.xhr = new XMLHttpRequest();
     };
@@ -75,8 +81,10 @@
     jsOMS.Message.Request.Request.getOS = function ()
     {
         for (let os in jsOMS.Message.Request.OSType) {
-            if (navigator.appVersion.toLowerCase().indexOf(jsOMS.Message.Request.OSType[os]) !== -1) {
-                return jsOMS.Message.Request.OSType[os];
+            if (jsOMS.Message.Request.OSType.hasOwnProperty(os)) {
+                if (navigator.appVersion.toLowerCase().indexOf(jsOMS.Message.Request.OSType[os]) !== -1) {
+                    return jsOMS.Message.Request.OSType[os];
+                }
             }
         }
     };
@@ -223,7 +231,23 @@
      */
     jsOMS.Message.Request.Request.prototype.setSuccess = function (callback)
     {
-        this.success = callback;
+        this.result[200] = callback;
+    };
+
+    /**
+     * Set result callback.
+     *
+     * @param {int} status Http response status
+     * @param {function} callback Callback
+     *
+     * @method
+     *
+     * @since  1.0.0
+     * @author Dennis Eichhorn <d.eichhorn@oms.com>
+     */
+    jsOMS.Message.Request.Request.prototype.setResultCallback = function (status, callback)
+    {
+        this.result[status] = callback;
     };
 
     /**
@@ -337,15 +361,23 @@
 
         self.xhr.onreadystatechange = function ()
         {
-            if (self.xhr.readyState === 4 && self.xhr.status === 200) {
-                self.success(self.xhr);
-            } else if (self.xhr.readyState === 2) {
-                // todo: handle server received request
-            } else if (self.xhr.readyState === 3) {
-                // todo: server is handling request
-            } else {
-                // todo: create handler for error returns
-                console.log(self.xhr);
+            switch (self.xhr.readyState) {
+                case 4:
+                    if (typeof this.result[self.xhr.status] === 'undefined') {
+                        self.result[0](self.xhr);
+                    } else {
+                        self.result[self.xhr.status](self.xhr);
+                    }
+                    break;
+                case 2:
+                    // todo: handle server received request
+                    break;
+                case 3:
+                    // todo: server is handling request
+                    break;
+                default:
+                    // todo: create handler for error returns
+                    console.log(self.xhr);
             }
         };