From 80b9dbdf9fe9a92482f976211a471036b1539621 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Tue, 31 May 2016 23:21:09 +0200
Subject: [PATCH] Fixing global variables

---
 Autoloader.js                        | 2 ++
 Math/Stochastic/Average.js           | 2 +-
 Message/Request/Request.js           | 2 ++
 Message/Response/Response.js         | 2 +-
 UI/Input.js                          | 5 ++---
 UI/Input/Keyboard/KeyboardManager.js | 5 +++--
 Uri/UriFactory.js                    | 2 +-
 Utils/oLib.js                        | 2 ++
 8 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/Autoloader.js b/Autoloader.js
index 4fb4389..386fb56 100644
--- a/Autoloader.js
+++ b/Autoloader.js
@@ -54,6 +54,8 @@
             length  = scripts.length;
 
         for (let i = 0; i < length; i++) {
+            /** global: URL */
+            /** @var {string} URL */
             scripts[i].src.replace(URL + '/', '');
 
             if (jsOMS.Autoloader.loaded.indexOf(scripts[i].src) === -1) {
diff --git a/Math/Stochastic/Average.js b/Math/Stochastic/Average.js
index af02338..9e82efd 100644
--- a/Math/Stochastic/Average.js
+++ b/Math/Stochastic/Average.js
@@ -26,6 +26,6 @@
             throw 'Division zero';
         }
 
-        return values.reduce((a, b) => a + b, 0) / count;
+        return values.reduce((a, b) => a + b, 0) / length;
     };
 }(window.jsOMS = window.jsOMS || {}));
\ No newline at end of file
diff --git a/Message/Request/Request.js b/Message/Request/Request.js
index 6aa10be..c44b6e9 100644
--- a/Message/Request/Request.js
+++ b/Message/Request/Request.js
@@ -26,6 +26,8 @@
         this.success       = null;
         this.type          = typeof type !== 'undefined' ? type : jsOMS.Message.Response.ResponseType.JSON;
         this.data          = {};
+
+        /** global: XMLHttpRequest */
         this.xhr           = new XMLHttpRequest();
     };
 
diff --git a/Message/Response/Response.js b/Message/Response/Response.js
index 04671e9..ca8e3a1 100644
--- a/Message/Response/Response.js
+++ b/Message/Response/Response.js
@@ -9,7 +9,7 @@
  * @license    OMS License 1.0
  * @version    1.0.0 * @since      1.0.0
  */
-(function (uriFactory, undefined)
+(function (jsOMS)
 {
     /** @namespace jsOMS.Message.Response */
     jsOMS.Autoloader.defineNamespace('jsOMS.Message.Response');
diff --git a/UI/Input.js b/UI/Input.js
index d673a9a..41b4748 100644
--- a/UI/Input.js
+++ b/UI/Input.js
@@ -64,7 +64,6 @@
                     case 'table':
                         break;
                 }
-                ;
             }
         });
 
@@ -92,7 +91,7 @@
     {
         this.clearDatalistOptions(datalist);
 
-        let request = new Request();
+        let request = new jsOMS.Message.Request();
         request.setData(input.value);
         request.setType(jsOMS.Message.Response.ResponseType.JSON);
         request.setUri(datalist.getAttribute('data-list-src'));
@@ -102,7 +101,7 @@
         {
             try {
                 let o              = JSON.parse(xhr.response),
-                    response       = new Response(o),
+                    response       = new jsOMS.Message.Response(o),
                     responseLength = response.count(),
                     tempResponse   = null,
                     success        = null;
diff --git a/UI/Input/Keyboard/KeyboardManager.js b/UI/Input/Keyboard/KeyboardManager.js
index d6ac0f7..915209d 100644
--- a/UI/Input/Keyboard/KeyboardManager.js
+++ b/UI/Input/Keyboard/KeyboardManager.js
@@ -66,7 +66,7 @@
         document.addEventListener('keyup', function keyBind(event)
         {
             if (self.down.length > 0) {
-                self.run(element);
+                self.run(element, event);
                 self.down = [];
             }
         });
@@ -76,11 +76,12 @@
      * Execute callback based on key presses.
      *
      * @param {string} element Container id
+     * @param {Object} event Key event
      *
      * @since  1.0.0
      * @author Dennis Eichhorn <d.eichhorn@oms.com>
      */
-    jsOMS.UI.Input.Keyboard.KeyboardManager.prototype.run = function (element)
+    jsOMS.UI.Input.Keyboard.KeyboardManager.prototype.run = function (element, event)
     {
         if (typeof this.elements[element] === 'undefined') {
             throw 'Unexpected elmenet!';
diff --git a/Uri/UriFactory.js b/Uri/UriFactory.js
index 16035bf..7f4d735 100644
--- a/Uri/UriFactory.js
+++ b/Uri/UriFactory.js
@@ -7,7 +7,7 @@
  * @license    OMS License 1.0
  * @version    1.0.0 * @since      1.0.0
  */
-(function (uriFactory, undefined)
+(function (jsOMS)
 {
     /** @namespace jsOMS.Uri.UriFactory */
     jsOMS.Autoloader.defineNamespace('jsOMS.Uri.UriFactory');
diff --git a/Utils/oLib.js b/Utils/oLib.js
index f768021..859747c 100644
--- a/Utils/oLib.js
+++ b/Utils/oLib.js
@@ -194,6 +194,7 @@
      */
     jsOMS.isNode = function (ele)
     {
+        /** global: Node */
         return (
             typeof Node === "object" ? ele instanceof Node :
             ele && typeof ele === "object" && typeof ele.nodeType === "number" && typeof ele.nodeName === "string"
@@ -216,6 +217,7 @@
      */
     jsOMS.isElement = function (o)
     {
+        /** global: HTMLElement */
         return (
             typeof HTMLElement === "object" ? o instanceof HTMLElement : o && typeof o === "object" && o !== null && o.nodeType === 1 && typeof o.nodeName === "string"
         );