Use const where possible

This commit is contained in:
Dennis Eichhorn 2017-01-02 18:34:43 +01:00
parent bd98df16ee
commit 577230348a
18 changed files with 81 additions and 76 deletions

View File

@ -65,7 +65,7 @@
self = typeof self !== 'undefined' ? self : this; self = typeof self !== 'undefined' ? self : this;
self.invalidate(); self.invalidate();
let length = self.particles.length; const length = self.particles.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
self.particles[i].draw(self.ctx); self.particles[i].draw(self.ctx);
@ -106,11 +106,12 @@
jsOMS.Animation.Canvas.ParticleAnimation.prototype.updateParticles = function () jsOMS.Animation.Canvas.ParticleAnimation.prototype.updateParticles = function ()
{ {
let particle, let particle,
length = this.particles.length,
pos, pos,
vel, vel,
radius; radius;
const length = this.particles.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
particle = this.particles[i]; particle = this.particles[i];
pos = particle.getPosition(); pos = particle.getPosition();
@ -157,12 +158,13 @@
*/ */
jsOMS.Animation.Canvas.ParticleAnimation.prototype.updateDistance = function (p1, p2) jsOMS.Animation.Canvas.ParticleAnimation.prototype.updateDistance = function (p1, p2)
{ {
let pos1 = p1.getPosition(), const pos1 = p1.getPosition(),
pos2 = p2.getPosition(), pos2 = p2.getPosition(),
dx = pos1.x - pos2.x, dx = pos1.x - pos2.x,
dy = pos1.y - pos2.y, dy = pos1.y - pos2.y,
dist = Math.sqrt(dx * dx + dy * dy), dist = Math.sqrt(dx * dx + dy * dy);
vel1 = p1.getVelocity(),
let vel1 = p1.getVelocity(),
vel2 = p2.getVelocity(); vel2 = p2.getVelocity();
// Draw line if particles are close // Draw line if particles are close

View File

@ -30,8 +30,8 @@
let paths = namespace.split('.'); let paths = namespace.split('.');
paths.splice(0, 1); paths.splice(0, 1);
let length = paths.length, const length = paths.length;
current = jsOMS; let current = jsOMS;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
if (typeof current[paths[i]] === 'undefined') { if (typeof current[paths[i]] === 'undefined') {
@ -53,7 +53,7 @@
*/ */
jsOMS.Autoloader.initPreloaded = function () jsOMS.Autoloader.initPreloaded = function ()
{ {
let scripts = document.getElementsByTagName('script'), const scripts = document.getElementsByTagName('script'),
length = scripts.length; length = scripts.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
@ -93,7 +93,7 @@
*/ */
jsOMS.Autoloader.include = function (file, callback) jsOMS.Autoloader.include = function (file, callback)
{ {
let length = file.length; const length = file.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
if (jsOMS.Autoloader.loaded.indexOf(file) === -1) { if (jsOMS.Autoloader.loaded.indexOf(file) === -1) {

View File

@ -41,9 +41,9 @@
*/ */
jsOMS.DataStorage.CookieJar.prototype.setCookie = function (cName, value, exdays, domain, path) jsOMS.DataStorage.CookieJar.prototype.setCookie = function (cName, value, exdays, domain, path)
{ {
var exdate = new Date(); const exdate = new Date();
exdate.setDate(exdate.getDate() + exdays); exdate.setDate(exdate.getDate() + exdays);
var cValue = encodeURI(value) + ((exdays === null) ? "" : "; expires=" + exdate.toUTCString()) + ";domain=" + domain + ";path=" + path; const cValue = encodeURI(value) + ((exdays === null) ? "" : "; expires=" + exdate.toUTCString()) + ";domain=" + domain + ";path=" + path;
document.cookie = cName + "=" + cValue; document.cookie = cName + "=" + cValue;
}; };
@ -61,8 +61,8 @@
*/ */
jsOMS.DataStorage.CookieJar.prototype.getCookie = function (cName) jsOMS.DataStorage.CookieJar.prototype.getCookie = function (cName)
{ {
var cValue = document.cookie; let cValue = document.cookie,
var cStart = cValue.indexOf(" " + cName + "="); cStart = cValue.indexOf(" " + cName + "=");
if (cStart === -1) { if (cStart === -1) {
cStart = cValue.indexOf(cName + "="); cStart = cValue.indexOf(cName + "=");
@ -72,7 +72,7 @@
cValue = null; cValue = null;
} else { } else {
cStart = cValue.indexOf("=", cStart) + 1; cStart = cValue.indexOf("=", cStart) + 1;
var cEnd = cValue.indexOf(";", cStart); let cEnd = cValue.indexOf(";", cStart);
if (cEnd === -1) { if (cEnd === -1) {
cEnd = cValue.length; cEnd = cValue.length;

View File

@ -326,12 +326,13 @@
*/ */
jsOMS.Message.Request.Request.prototype.queryfy = function (obj) jsOMS.Message.Request.Request.prototype.queryfy = function (obj)
{ {
let str = []; const str = [];
for (let p in obj) { for (let p in obj) {
if (obj.hasOwnProperty(p)) { if (obj.hasOwnProperty(p)) {
str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p])); str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p]));
} }
} }
return str.join("&"); return str.join("&");
}; };
@ -347,7 +348,7 @@
*/ */
jsOMS.Message.Request.Request.prototype.send = function () jsOMS.Message.Request.Request.prototype.send = function ()
{ {
let self = this; const self = this;
if (self.xhr.readyState !== 1) { if (self.xhr.readyState !== 1) {
self.xhr.open(this.method, jsOMS.Uri.UriFactory.build(this.uri)); self.xhr.open(this.method, jsOMS.Uri.UriFactory.build(this.uri));

View File

@ -42,7 +42,7 @@
*/ */
jsOMS.UI.ActionManager.prototype.bind = function (id) jsOMS.UI.ActionManager.prototype.bind = function (id)
{ {
let uiElements = typeof e === 'undefined' ? document.querySelectorAll('input, select, textarea, button, data') : [e], const uiElements = typeof e === 'undefined' ? document.querySelectorAll('input, select, textarea, button, data') : [e],
length = uiElements.length; length = uiElements.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
@ -64,11 +64,12 @@
*/ */
jsOMS.UI.ActionManager.prototype.bindElement = function (e) jsOMS.UI.ActionManager.prototype.bindElement = function (e)
{ {
let listeners = JSON.parse(e.getAttribute('data-action')), const listeners = JSON.parse(e.getAttribute('data-action')),
listenerLength = listeners.length, listenerLength = listeners.length,
actionLength = 0,
self = this; self = this;
let actionLength = 0;
// For everey action an event is registered // For everey action an event is registered
for (let i = 0; i < listenerLength; i++) { for (let i = 0; i < listenerLength; i++) {
actionLength = listeners[i].action.length; actionLength = listeners[i].action.length;
@ -105,7 +106,7 @@
*/ */
jsOMS.UI.ActionManager.prototype.runAction = function (e, action) jsOMS.UI.ActionManager.prototype.runAction = function (e, action)
{ {
let self = this; const self = this;
console.log(action.type); console.log(action.type);
console.log(this.actions); console.log(this.actions);

View File

@ -51,7 +51,7 @@
if (typeof id !== 'undefined') { if (typeof id !== 'undefined') {
this.bindElement(id); this.bindElement(id);
} else { } else {
let elements = document.querySelectorAll('[draggable]'), const elements = document.querySelectorAll('[draggable]'),
length = elements.length; length = elements.length;
for (var i = 0; i < length; i++) { for (var i = 0; i < length; i++) {
@ -72,7 +72,7 @@
*/ */
jsOMS.UI.DragNDrop.prototype.bindElement = function (id) jsOMS.UI.DragNDrop.prototype.bindElement = function (id)
{ {
let element = document.getElementById(id); const element = document.getElementById(id);
console.log(id); console.log(id);
element.addEventListener('dragstart', function(event) { element.addEventListener('dragstart', function(event) {

View File

@ -79,7 +79,7 @@
if (typeof id !== 'undefined' && typeof this.ignore[id] === 'undefined') { if (typeof id !== 'undefined' && typeof this.ignore[id] === 'undefined') {
this.bindForm(id); this.bindForm(id);
} else { } else {
let forms = document.getElementsByTagName('form'), const forms = document.getElementsByTagName('form'),
length = forms.length; length = forms.length;
for (var i = 0; i < length; i++) { for (var i = 0; i < length; i++) {
@ -105,12 +105,12 @@
return; return;
} }
let self = this; const self = this;
this.forms[id] = new jsOMS.Views.FormView(id); this.forms[id] = new jsOMS.Views.FormView(id);
this.unbind(id); this.unbind(id);
let submits = this.forms[id].getSubmit(), const submits = this.forms[id].getSubmit(),
length = submits.length; length = submits.length;
for(let i = 0; i < length; i++) { for(let i = 0; i < length; i++) {
@ -158,9 +158,9 @@
jsOMS.UI.FormManager.prototype.submit = function (form) jsOMS.UI.FormManager.prototype.submit = function (form)
{ {
/* Handle injects */ /* Handle injects */
let self = this, const self = this,
injects = form.getSubmitInjects(), injects = form.getSubmitInjects();
counter = 0; let counter = 0;
// todo: test if attach necessary (maybe already attached in event manager) // todo: test if attach necessary (maybe already attached in event manager)
// Register normal form behavior // Register normal form behavior
@ -203,7 +203,7 @@
} }
/* Handle default submit */ /* Handle default submit */
let request = new jsOMS.Message.Request.Request(), const request = new jsOMS.Message.Request.Request(),
self = this; self = this;
request.setData(form.getData()); request.setData(form.getData());
@ -214,10 +214,10 @@
request.setSuccess(function (xhr) request.setSuccess(function (xhr)
{ {
try { try {
let o = JSON.parse(xhr.response), const o = JSON.parse(xhr.response),
response = new jsOMS.Message.Response.Response(o), response = new jsOMS.Message.Response.Response(o),
responseLength = response.count(), responseLength = response.count();
tempResponse = null, let tempResponse = null,
success = null; success = null;
/* Handle responses (can be multiple response object) */ /* Handle responses (can be multiple response object) */

View File

@ -42,7 +42,7 @@
throw 'Input element required' throw 'Input element required'
} }
let self = this; const self = this;
input.addEventListener('change', function changeBind(event) input.addEventListener('change', function changeBind(event)
{ {
@ -96,7 +96,7 @@
{ {
this.clearDatalistOptions(datalist); this.clearDatalistOptions(datalist);
let request = new jsOMS.Message.Request(); const request = new jsOMS.Message.Request();
request.setData(input.value); request.setData(input.value);
request.setType(jsOMS.Message.Response.ResponseType.JSON); request.setType(jsOMS.Message.Response.ResponseType.JSON);
request.setUri(datalist.getAttribute('data-list-src')); request.setUri(datalist.getAttribute('data-list-src'));
@ -105,10 +105,10 @@
request.setSuccess(function (xhr) request.setSuccess(function (xhr)
{ {
try { try {
let o = JSON.parse(xhr.response), const o = JSON.parse(xhr.response),
response = new jsOMS.Message.Response(o), response = new jsOMS.Message.Response(o),
responseLength = response.count(), responseLength = response.count();
tempResponse = null, let tempResponse = null,
success = null; success = null;
for (let k = 0; k < responseLength; k++) { for (let k = 0; k < responseLength; k++) {
@ -146,7 +146,7 @@
*/ */
jsOMS.UI.Input.clearDatalistOptions = function (datalist) jsOMS.UI.Input.clearDatalistOptions = function (datalist)
{ {
let length = datalist.options.length; const length = datalist.options.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
datalist.remove(0); datalist.remove(0);

View File

@ -57,7 +57,7 @@
*/ */
jsOMS.UI.Input.Keyboard.KeyboardManager.prototype.bind = function (element) jsOMS.UI.Input.Keyboard.KeyboardManager.prototype.bind = function (element)
{ {
let self = this; const self = this;
// todo: implement keyboard for selected elements right now only global hotkeys possible // todo: implement keyboard for selected elements right now only global hotkeys possible
document.addEventListener('keydown', function keyBind(event) document.addEventListener('keydown', function keyBind(event)
@ -89,10 +89,10 @@
throw 'Unexpected elmenet!'; throw 'Unexpected elmenet!';
} }
let actions = this.elements[element], const actions = this.elements[element],
length = actions.length, length = actions.length,
keyLength = this.down.length, keyLength = this.down.length;
match = false; let match = false;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
for (let j = 0; j < keyLength; j++) { for (let j = 0; j < keyLength; j++) {

View File

@ -59,7 +59,7 @@
*/ */
jsOMS.UI.Input.Mouse.MouseManager.prototype.bind = function (element, type) jsOMS.UI.Input.Mouse.MouseManager.prototype.bind = function (element, type)
{ {
let self = this, const self = this,
e = document.getElementById(element); e = document.getElementById(element);
if (e === null) { if (e === null) {
@ -79,7 +79,7 @@
e.addEventListener('mouseup', function (event) e.addEventListener('mouseup', function (event)
{ {
let duration = new Date().getTime() - self.click.time; const duration = new Date().getTime() - self.click.time;
if (duration > 650) { if (duration > 650) {
self.run(element, event); self.run(element, event);
@ -110,7 +110,7 @@
throw 'Unexpected elmenet!'; throw 'Unexpected elmenet!';
} }
let actions = this.elements[element], const actions = this.elements[element],
length = actions.length; length = actions.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {

View File

@ -52,12 +52,12 @@
*/ */
jsOMS.UI.Input.Touch.TouchManager.prototype.add = function (surface) jsOMS.UI.Input.Touch.TouchManager.prototype.add = function (surface)
{ {
let e = document.getElementById(surface), const e = document.getElementById(surface),
self = this; self = this;
e.addEventListener('touchstart', function (event) e.addEventListener('touchstart', function (event)
{ {
let touch = this.changedTouches[0]; const touch = this.changedTouches[0];
self.activeSwipe.startX = touch.pageX; self.activeSwipe.startX = touch.pageX;
self.activeSwipe.startY = touch.pageY; self.activeSwipe.startY = touch.pageY;
@ -73,7 +73,7 @@
e.addEventListener('touchend', function (event) e.addEventListener('touchend', function (event)
{ {
let touch = this.changedTouches[0], const touch = this.changedTouches[0],
distX = touch.pageX - self.activeSwipe.startX, distX = touch.pageX - self.activeSwipe.startX,
distY = touch.pageY - self.activeSwipe.startY, distY = touch.pageY - self.activeSwipe.startY,
elapsedTime = new Date().getTime() - self.activeSwipe.time; elapsedTime = new Date().getTime() - self.activeSwipe.time;
@ -105,7 +105,7 @@
document.dispatchEvent(rightClick); document.dispatchEvent(rightClick);
} else if (elapsedTime < 500) { } else if (elapsedTime < 500) {
let e = new Event('keyup'); const e = new Event('keyup');
if (distY > 100) { if (distY > 100) {
e.keyCode = 38; e.keyCode = 38;

View File

@ -59,12 +59,12 @@
*/ */
jsOMS.UI.TabManager.prototype.bindElement = function (e) jsOMS.UI.TabManager.prototype.bindElement = function (e)
{ {
var nodes = e.querySelectorAll('.tab-links a'); const nodes = e.querySelectorAll('.tab-links a');
nodes.addEventListener('click', function (evt) nodes.addEventListener('click', function (evt)
{ {
/* Change Tab */ /* Change Tab */
var attr = this.getAttribute('href').substring(1), const attr = this.getAttribute('href').substring(1),
cont = this.parentNode.parentNode.parentNode.children[1]; cont = this.parentNode.parentNode.parentNode.children[1];
jsOMS.removeClass(jsOMS.getByClass(this.parentNode.parentNode, 'active'), 'active'); jsOMS.removeClass(jsOMS.getByClass(this.parentNode.parentNode, 'active'), 'active');

View File

@ -39,7 +39,7 @@
if (typeof id !== 'undefined') { if (typeof id !== 'undefined') {
this.bindElement(document.getElementById(id)); this.bindElement(document.getElementById(id));
} else { } else {
var tables = document.querySelectorAll('.tables'); const tables = document.querySelectorAll('.tables');
for (var i = 0; i < tables.length; i++) { for (var i = 0; i < tables.length; i++) {
this.bindElement(tables[i]); this.bindElement(tables[i]);

View File

@ -51,7 +51,7 @@
this.actionManager.bind(); this.actionManager.bind();
this.dragNDrop.bind(); this.dragNDrop.bind();
} else { } else {
let tag = document.getElementById(id); const tag = document.getElementById(id);
switch (tag.tagName) { switch (tag.tagName) {
case 'form': case 'form':

View File

@ -55,7 +55,7 @@
{ {
mode = typeof mode === 'undefined' ? 'php' : mode; mode = typeof mode === 'undefined' ? 'php' : mode;
let query, key = ['source', 'scheme', 'authority', 'userInfo', 'user', 'pass', 'host', 'port', const key = ['source', 'scheme', 'authority', 'userInfo', 'user', 'pass', 'host', 'port',
'relative', 'path', 'directory', 'file', 'query', 'fragment' 'relative', 'path', 'directory', 'file', 'query', 'fragment'
], ],
parser = { parser = {
@ -68,9 +68,9 @@
throw new Error('Unexpected parsing mode.', 'UriFactory', 52); throw new Error('Unexpected parsing mode.', 'UriFactory', 52);
} }
let m = parser[mode].exec(str), const m = parser[mode].exec(str),
uri = {}, uri = {};
i = 14; let i = 14;
while (i--) { while (i--) {
if (m[i]) { if (m[i]) {
@ -100,7 +100,7 @@
{ {
name = name.replace(/[\[]/, "\\[").replace(/[\]]/, "\\]"); name = name.replace(/[\[]/, "\\[").replace(/[\]]/, "\\]");
let regex = new RegExp("[\\?&]*" + name + "=([^&#]*)"), const regex = new RegExp("[\\?&]*" + name + "=([^&#]*)"),
results = regex.exec(query); results = regex.exec(query);
return results === null ? '' : decodeURIComponent(results[1].replace(/\+/g, ' ')); return results === null ? '' : decodeURIComponent(results[1].replace(/\+/g, ' '));
@ -108,15 +108,15 @@
jsOMS.Uri.Http.getAllUriQueryParameters = function (query) jsOMS.Uri.Http.getAllUriQueryParameters = function (query)
{ {
let keyValPairs = [], const keyValPairs = [],
params = {}, params = {};
pairNum = null; let pairNum = null;
if (query.length) { if (query.length) {
keyValPairs = query.split('&'); keyValPairs = query.split('&');
for (pairNum in keyValPairs) { for (pairNum in keyValPairs) {
let key = keyValPairs[pairNum].split('=')[0]; const key = keyValPairs[pairNum].split('=')[0];
if (!key.length) { if (!key.length) {
continue; continue;
@ -137,7 +137,7 @@
{ {
this.uri = uri; this.uri = uri;
let parsed = jsOMS.Uri.Http.parseUrl(this.uri, 'php'); const parsed = jsOMS.Uri.Http.parseUrl(this.uri, 'php');
this.scheme = parsed['scheme']; this.scheme = parsed['scheme'];
this.host = parsed['host']; this.host = parsed['host'];

View File

@ -69,8 +69,8 @@
jsOMS.Uri.UriFactory.clearLike = function(pattern) jsOMS.Uri.UriFactory.clearLike = function(pattern)
{ {
let success = false, let success = false;
regexp = new Regexp(pattern); const regexp = new Regexp(pattern);
for(let key in jsOMS.Uri.UriFactory.uri) { for(let key in jsOMS.Uri.UriFactory.uri) {
if(jsOMS.Uri.UriFactory.uri.hasOwnProperty(key) && regexp.test(key)) { if(jsOMS.Uri.UriFactory.uri.hasOwnProperty(key) && regexp.test(key)) {
@ -98,7 +98,7 @@
*/ */
jsOMS.Uri.UriFactory.unique = function (url) jsOMS.Uri.UriFactory.unique = function (url)
{ {
let parts = url.split('?'); const parts = url.split('?');
if (parts.length >= 2) { if (parts.length >= 2) {
let full = parts[1], let full = parts[1],
@ -146,7 +146,7 @@
*/ */
jsOMS.Uri.UriFactory.build = function (uri, toMatch) jsOMS.Uri.UriFactory.build = function (uri, toMatch)
{ {
let current = jsOMS.Uri.Http.parseUrl(window.location.href); const current = jsOMS.Uri.Http.parseUrl(window.location.href);
let parsed = uri.replace(new RegExp('\{[\/#\?%@\.\$][a-zA-Z0-9\-]*\}', 'g'), function (match) let parsed = uri.replace(new RegExp('\{[\/#\?%@\.\$][a-zA-Z0-9\-]*\}', 'g'), function (match)
{ {
match = match.substr(1, match.length - 2); match = match.substr(1, match.length - 2);

View File

@ -268,7 +268,7 @@
*/ */
jsOMS.addEventListenerToAll = function (e, event, callback) jsOMS.addEventListenerToAll = function (e, event, callback)
{ {
let length = e.length; const length = e.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
e[i].addEventListener(event, callback); e[i].addEventListener(event, callback);
@ -290,7 +290,7 @@
*/ */
jsOMS.merge = function (target, source) jsOMS.merge = function (target, source)
{ {
let out = jsOMS.clone(target); const out = jsOMS.clone(target);
for (let p in source) { for (let p in source) {
if (source.hasOwnProperty(p)) { if (source.hasOwnProperty(p)) {

View File

@ -133,7 +133,7 @@
*/ */
jsOMS.Views.FormView.prototype.getFormElements = function () jsOMS.Views.FormView.prototype.getFormElements = function ()
{ {
let form = document.getElementById(this.id), const form = document.getElementById(this.id),
selects = form.getElementsByTagName('select'), selects = form.getElementsByTagName('select'),
textareas = form.getElementsByTagName('textarea'), textareas = form.getElementsByTagName('textarea'),
inputs = form.getElementsByTagName('input'), inputs = form.getElementsByTagName('input'),
@ -152,10 +152,11 @@
*/ */
jsOMS.Views.FormView.prototype.getData = function () jsOMS.Views.FormView.prototype.getData = function ()
{ {
let data = {}, const data = {},
elements = this.getFormElements(), elements = this.getFormElements(),
length = elements.length, length = elements.length;
value = null;
let value = null;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
if(elements[i].tagName.toLowerCase() === 'canvas') { if(elements[i].tagName.toLowerCase() === 'canvas') {
@ -193,7 +194,7 @@
*/ */
jsOMS.Views.FormView.prototype.isValid = function () jsOMS.Views.FormView.prototype.isValid = function ()
{ {
let elements = this.getFormElements(), const elements = this.getFormElements(),
length = elements.length; length = elements.length;
try { try {
@ -275,7 +276,7 @@
this.method = document.getElementById(this.id).attributes['method'].value; this.method = document.getElementById(this.id).attributes['method'].value;
this.action = document.getElementById(this.id).action; this.action = document.getElementById(this.id).action;
let elements = this.getFormElements(), const elements = this.getFormElements(),
length = elements.length; length = elements.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
@ -304,7 +305,7 @@
*/ */
jsOMS.Views.FormView.prototype.unbind = function () jsOMS.Views.FormView.prototype.unbind = function ()
{ {
let elements = this.getFormElements(), const elements = this.getFormElements(),
length = elements.length; length = elements.length;
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {