Jingga/jsOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/jsOMS.git synced 2026-02-17 01:38:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup todos

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-12-31 23:36:55 +01:00
parent 0c226ca9df
commit 3423761881
4 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
UI/ActionManager.js
View File

@ -79,7 +79,6 @@ export class ActionManager
return; return;
} }
// todo: validate json, if invalid log error
const listeners = JSON.parse(e.getAttribute('data-action')), const listeners = JSON.parse(e.getAttribute('data-action')),
listenerLength = listeners.length, listenerLength = listeners.length,
self = this; self = this;

1
Uri/UriFactory.js
View File

@ -197,7 +197,6 @@ export class UriFactory
} else if (match.indexOf('?') === 0) { } else if (match.indexOf('?') === 0) {
return Http.getUriQueryParameter(current.query, match.substr(1)); return Http.getUriQueryParameter(current.query, match.substr(1));
} else if (match.indexOf('/') === 0) { } else if (match.indexOf('/') === 0) {
// todo: second match should return second path
return 'ERROR PATH'; return 'ERROR PATH';
} else if (match === '%') { } else if (match === '%') {
return window.location.href; return window.location.href;

12
Utils/GeneralUtils.js
View File

@ -64,13 +64,17 @@
}; };
/** /**
* todo: implement deep clone/copy * Shallow clones an object.
* @param obj *
* @returns {*} * @param {Object} obj Object to clone
*
* @returns {Object}
*
* @since 1.0.0
*/ */
jsOMS.clone = function (obj) jsOMS.clone = function (obj)
{ {
return obj; return { ...obj };
}; };
/** /**

12
Utils/oLib.js
View File

@ -471,13 +471,17 @@
}; };
/** /**
* todo: implement deep clone/copy * Shallow clones an object.
* @param obj *
* @returns {*} * @param {Object} obj Object to clone
*
* @returns {Object}
*
* @since 1.0.0
*/ */
jsOMS.clone = function (obj) jsOMS.clone = function (obj)
{ {
return obj; return { ...obj };
}; };
jsOMS.isset = function (variable) jsOMS.isset = function (variable)