cleanup todos

This commit is contained in:
Dennis Eichhorn 2019-12-31 23:36:55 +01:00
parent 0c226ca9df
commit 3423761881
4 changed files with 16 additions and 10 deletions

View File

@ -79,7 +79,6 @@ export class ActionManager
return;
}
// todo: validate json, if invalid log error
const listeners = JSON.parse(e.getAttribute('data-action')),
listenerLength = listeners.length,
self = this;

View File

@ -197,7 +197,6 @@ export class UriFactory
} else if (match.indexOf('?') === 0) {
return Http.getUriQueryParameter(current.query, match.substr(1));
} else if (match.indexOf('/') === 0) {
// todo: second match should return second path
return 'ERROR PATH';
} else if (match === '%') {
return window.location.href;

View File

@ -64,13 +64,17 @@
};
/**
* todo: implement deep clone/copy
* @param obj
* @returns {*}
* Shallow clones an object.
*
* @param {Object} obj Object to clone
*
* @returns {Object}
*
* @since 1.0.0
*/
jsOMS.clone = function (obj)
{
return obj;
return { ...obj };
};
/**

View File

@ -471,13 +471,17 @@
};
/**
* todo: implement deep clone/copy
* @param obj
* @returns {*}
* Shallow clones an object.
*
* @param {Object} obj Object to clone
*
* @returns {Object}
*
* @since 1.0.0
*/
jsOMS.clone = function (obj)
{
return obj;
return { ...obj };
};
jsOMS.isset = function (variable)