From 20c4176c522ed2a7e77bb13552795be83d6b40ed Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Fri, 23 Nov 2018 11:36:32 +0100
Subject: [PATCH] Adjust todos and add loggign

---
 Event/EventManager.js      | 1 -
 Message/Request/Request.js | 5 ++---
 Views/FormView.js          | 5 +++++
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/Event/EventManager.js b/Event/EventManager.js
index 6004564..3575cae 100644
--- a/Event/EventManager.js
+++ b/Event/EventManager.js
@@ -120,7 +120,6 @@
             }
 
             if (!this.hasOutstanding(group)) {
-                // todo if it is route then call dispatcher?
                 this.callbacks[group].lastRun = Date.now();
                 this.callbacks[group].func(data);
 
diff --git a/Message/Request/Request.js b/Message/Request/Request.js
index 338c51b..b75934a 100644
--- a/Message/Request/Request.js
+++ b/Message/Request/Request.js
@@ -30,10 +30,9 @@
 
             this.requestHeader['Content-Type'] = this.setContentTypeBasedOnType(this.type);
 
-            // todo: create log;
             this.result[0] = function()
             {
-                //console.log('invalid response');
+                jsOMS.Log.Logger.instance.error('Invalid response code.');
             };
 
             /** global: XMLHttpRequest */
@@ -387,7 +386,7 @@
                         }
                         break;
                     default:
-                        // todo: create handler for error returns
+                        jsOMS.Log.Logger.instance.warning('Unhandled ready state change.');
                 }
             };
 
diff --git a/Views/FormView.js b/Views/FormView.js
index 8fe7c97..a43cabf 100644
--- a/Views/FormView.js
+++ b/Views/FormView.js
@@ -158,6 +158,11 @@
                 external    = document.querySelectorAll('[form=' + this.id + ']'),
                 inputLength = inputs.length;
 
+            // todo: handle trigger element. check which element triggered the submit and pass it's name+value
+            // the reason for this is, there may be multiple buttons in a form which trigger a send
+            // sometimes even a checkbox or drop down could trigger a send
+            // Maybe it makes sense to do this however at a different place e.g. the actual data submit
+
             for (let i = 0; i < inputLength; ++i) {
                 if (inputs[i].type === 'checkbox' && !inputs[i].checked) {
                     delete inputs[i];