From a45aa3df3ebf06b8d1aef3ee1a718990f5a08274 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Sat, 2 Oct 2021 22:43:47 +0200 Subject: [PATCH] update unit tests and settings handling --- Project/PROJECT.md | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/Project/PROJECT.md b/Project/PROJECT.md index 5eacdc8..5c66810 100644 --- a/Project/PROJECT.md +++ b/Project/PROJECT.md @@ -134,7 +134,7 @@ Todos/tasks which are not important enough to be part of the milestones. | medium | | **Unit tests**
All Modules/\*\*/Models/\*, Modules/Controller/\* | | medium | | **Modules**
Find a way to handle optional modules (e.g. comment module in the news module) in the past the Mapper was modified (comments were removed) if the comment module was installed. Somehow this is no longer available but maybe another solution could be a different Mapper which is replaced if the comment module is installed. But instead of replacing a complete file, a diff should be generated between the files and the ADDED lines should be merged. How to handle uninstall because here it doesn't work? I would need to know exactly what to remove. | | medium | | **DataMapper**
In the DataMapper implement iterable fetch. Currently all models are returned in one go, additionally an iterator should be returned for iterable access in case of MANY results (e.g. Exchange module) | -| low | | **Unit tests**
[phpOMS] ModuleManager->installApplications
[phpOMS] StatusAbstract->installRoutes
[phpOMS] StatusAbstract->installHooks
[phpOMS] StatusAbstract->activateHooks
[phpOMS] StatusAbstract->deactivateHooks
[phpOMS] StatusAbstract->uninstallHooks
[phpOMS] ModuleAbstract->createModels
[phpOMS] ModuleAbstract->updateModel
[phpOMS] ModuleAbstract->createModel
[phpOMS] ModuleAbstract->getLocalization
[phpOMS] InstallerAbstract->createTables
[phpOMS] InstallerAbstract->reInit
[phpOMS] Graph->findAllReachableNodesDFS
[phpOMS] Graph->getAllPathsBetweenNodes
[phpOMS] Graph->countAllPathsBetweenNodes
[phpOMS] Graph->longestPathBetweenNodes
[phpOMS] Graph->shortestPathBetweenNodes
[phpOMS] Graph->isConnected
[phpOMS] Node->getEdgeByNeighbor
[Model] CoreSettings->create | +| low | | **Unit tests**
[phpOMS] Graph->findAllReachableNodesDFS
[phpOMS] Graph->getAllPathsBetweenNodes
[phpOMS] Graph->countAllPathsBetweenNodes
[phpOMS] Graph->longestPathBetweenNodes
[phpOMS] Graph->shortestPathBetweenNodes
[phpOMS] Graph->isConnected
[phpOMS] Node->getEdgeByNeighbor | | low | | **ER diagrams**
Checklist
Contact
DatabaseEditor
Draw
Messages
Monitoring
Shop | | low | | **Code cleanup**
Many modules still have unnecessary getters/setters. This should be replaced with puplic members. Check the Developer-Guide on when to use getters/setters. | | low | | **UI tabs**
[Template] Fix tab indices's. On many pages the tab indices's are broken (tabs, table/list, links, forms) | @@ -207,14 +207,14 @@ Todos/tasks which are not important enough to be part of the milestones. | low | | **DataMapperAbstract**
Implement data binding | | low | | **DataMappers**
Use `Mapper::TABLE` or string names in the mappers. At the moment both can be found. This is not concise. The `Mapper::TABLE` name is preferred in case of name changes. | | low | | **Email**
Find a way to localize some hard coded email content. Pass localization array? Manually overwrite email body if a hard coded/default message should be returned (maybe by checking for a flag/status code)? | -| low | | **SettingMapper & CoreSettings**
Consider to merge? Maybe only use the mapper, maybe let the CoreSettings use the `Setting` and `SettingMapper` | | low | | **Temp directory**
Consider to create a temp directory in the main directory (Orange-Management) which can be used by all modules etc. Alternatively create this temp directory in `Modules/Media/Files` | #### Archived -| Priority | Done | Task | -| -------- | ---- | ---- | -| | | | +| Priority | Done | Task | +| -------- | ---------- | ------------------------------------------------------------ | +| low | 2021.10.02 | **Unit tests**
[phpOMS] ModuleManager->installApplications
[phpOMS] StatusAbstract->installRoutes
[phpOMS] StatusAbstract->installHooks
[phpOMS] StatusAbstract->activateHooks
[phpOMS] StatusAbstract->deactivateHooks
[phpOMS] StatusAbstract->uninstallHooks
[phpOMS] ModuleAbstract->createModels
[phpOMS] ModuleAbstract->updateModel
[phpOMS] ModuleAbstract->createModel
[phpOMS] ModuleAbstract->getLocalization
[phpOMS] InstallerAbstract->createTables
[phpOMS] InstallerAbstract->reInit
[Model] CoreSettings->create | +| low | 2021.10.02 | **SettingMapper & CoreSettings**
Consider to merge? Maybe only use the mapper, maybe let the CoreSettings use the `Setting` and `SettingMapper` | ## Features @@ -477,7 +477,7 @@ class TestMapper extends DataMapperFactory #### New -* +* Improved settings handling by using `Setting` and `SettingMapper` in the `CoreSettings` file #### Bug fixes @@ -485,4 +485,6 @@ class TestMapper extends DataMapperFactory #### Other -* +##### Tests + +* Added various tests (approx. 2% additional line coverage).