Jingga/Developer-Guide
1
0
Fork 0
mirror of https://github.com/Karaka-Management/Developer-Guide.git synced 2026-02-02 22:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

make id public, organigram impl. media password/encryption, settings bug fix, Money->FloatInt change, ...

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-05-06 11:42:05 +00:00
parent c03e610811
commit 03d25fd37a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
standards/general.md
View File

@ -24,11 +24,19 @@ Files must end with a new line element `\n`.
## Member variables ## Member variables
Member variables should be public unless there is absolutely no reason directly access them or additional data manipulation upon setting, changing or returning them is required. Member variables should be public unless there is absolutely no reason to directly access them or additional data manipulation upon setting, changing or returning them is required.
### Getters/Setters ### Getters/Setters
Getters and setters for member variables should be kept at a minimum and only used when they actually perform additional actions, such as additional type checks, data manipulation, ... Getters and setters for member variables should be kept at a absolute minimum and only used when they actually perform additional actions.
### Why are we using public so much?
* Private/protected adds a huge amount of unneccessary typing without gaining much/anything
* Getters/setters may hide unsuspecting side effects
* Adding additional functionality afterwards if it becomes necessary is easy by changing the member to private and letting the static code inspection tools find the callers
* Performance overhead (function calls, data mappers)
* Private or protected doesn't add any security due to unserialization and reflections
## Indention ## Indention