From fbf703b4dba6910f85808cc62e51b6aca3d3b6bf Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Fri, 17 May 2024 14:15:42 +0000
Subject: [PATCH] inspection fixes

---
 Config/phpcs.xml    | 11 ++++-------
 Config/phpstan.neon |  7 ++++---
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/Config/phpcs.xml b/Config/phpcs.xml
index 96f7f77..e806b91 100755
--- a/Config/phpcs.xml
+++ b/Config/phpcs.xml
@@ -66,11 +66,11 @@
 <rule ref="Generic.PHP.DisallowAlternativePHPTags"/>
 <rule ref="Generic.PHP.DisallowShortOpenTag"/>
 <rule ref="Generic.PHP.DiscourageGoto"/>
-<!--<rule ref="Generic.PHP.ForbiddenFunctions">
+<rule ref="Generic.PHP.ForbiddenFunctions">
     <properties>
         <property name="forbiddenFunctions" type="array" value="delete=>unset,print=>echo,create_function=>null" />
     </properties>
-</rule>-->
+</rule>
 <rule ref="Generic.Files.ByteOrderMark"/>
 <!--<rule ref="Generic.Files.LineLength">
     <properties>
@@ -164,7 +164,6 @@
     <exclude-pattern>*Pdf.php</exclude-pattern><!-- Just a wrapper -->
     <exclude-pattern>*Excel.php</exclude-pattern><!-- Just a wrapper -->
     <exclude-pattern>*/tests/*</exclude-pattern><!-- Tests don't always have side effects -->
-    <exclude-pattern>*/Interfaces/*</exclude-pattern><!-- Interfaces use require_once due to unknown upload locations and therefore no autoloading -->
 </rule>
 <rule ref="PSR2.Classes.ClassDeclaration"/>
 <rule ref="PSR2.Classes.PropertyDeclaration"/>
@@ -206,12 +205,11 @@
         <property name="ignoreNewlines" value="true"/>
     </properties>
 </rule>
-<!--<rule ref="Squiz.WhiteSpace.OperatorSpacing">
+<rule ref="Squiz.WhiteSpace.OperatorSpacing">
     <properties>
         <property name="ignoreNewlines" value="true"/>
     </properties>
-    <exclude-pattern>*HttpUri.js</exclude-pattern>--><!-- Regex false positive -->
-<!--</rule>-->
+</rule>
 <rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing">
 </rule>
 <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
@@ -221,6 +219,5 @@
         <property name="tabIndent" value="true"/>
     </properties>
     <exclude-pattern>*ResponseType.js</exclude-pattern>
-    <exclude-pattern>*HttpUri.js</exclude-pattern>
 </rule>
 </ruleset>
\ No newline at end of file
diff --git a/Config/phpstan.neon b/Config/phpstan.neon
index 3bc439f..ae0b092 100755
--- a/Config/phpstan.neon
+++ b/Config/phpstan.neon
@@ -8,9 +8,6 @@ parameters:
     universalObjectCratesClasses:
         - Stripe\StripeObject
     reportUnmatchedIgnoredErrors: false
-    inferPrivatePropertyTypeFromConstructor: true
-    checkMissingIterableValueType: false
-    checkGenericClassInNonGenericObjectType: false
     treatPhpDocTypesAsCertain: false
     excludePaths:
         - *.tpl.php
@@ -56,6 +53,10 @@ parameters:
         - *Datamatrix.php
         - *QR.php
     ignoreErrors:
+        -
+          identifier: missingType.iterableValue
+        -
+          identifier: missingType.generics
         - '#^Call to an undefined method phpOMS\\Module\\ModuleAbstract::[.]*#'
         - '#expects phpOMS\\Algorithm\\PathFinding\\JumpPointNode\|null, phpOMS\\Algorithm\\PathFinding\\Node\|null given#'
         - '#should return array<phpOMS\\Algorithm\\PathFinding\\Node> but returns array<int, phpOMS\\Algorithm\\PathFinding\\Node\|null#'