From 87d605aaab282417a93a17139c7e4dc72f03ab15 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Sun, 28 Jan 2018 22:04:12 +0100
Subject: [PATCH] Add inspection configs

---
 Config/phpcs.xml | 84 +++++++++++++++++++++++++++++++++++++++++++++
 Config/phpmd.xml | 88 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 172 insertions(+)
 create mode 100644 Config/phpcs.xml
 create mode 100644 Config/phpmd.xml

diff --git a/Config/phpcs.xml b/Config/phpcs.xml
new file mode 100644
index 0000000..3eb8616
--- /dev/null
+++ b/Config/phpcs.xml
@@ -0,0 +1,84 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="default">
+<description></description>
+<exclude-pattern>*.tpl.php</exclude-pattern>
+<arg value="q"/>
+<rule ref="Generic.Classes.DuplicateClassName"/>
+<rule ref="Generic.CodeAnalysis.EmptyStatement"/>
+<rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall"/>
+<rule ref="Generic.CodeAnalysis.JumbledIncrementer"/>
+<rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
+<rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/>
+<rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
+<rule ref="Generic.Commenting.Todo"/>
+<rule ref="Generic.Commenting.Fixme"/>
+<rule ref="Generic.ControlStructures.InlineControlStructure"/>
+<rule ref="Generic.Files.ByteOrderMark"/>
+<rule ref="Generic.Files.LineEndings"/>
+<rule ref="Generic.Files.LineLength">
+    <properties>
+        <property name="lineLimit" value="150"/>
+        <property name="absoluteLineLimit" value="250"/>
+    </properties>
+</rule>
+<rule ref="Generic.Formatting.DisallowMultipleStatements">
+    <exclude-pattern>*/tests/*</exclude-pattern><!-- inline function definition -->
+</rule>
+<rule ref="Generic.Formatting.MultipleStatementAlignment"/>
+<rule ref="Generic.Formatting.SpaceAfterCast"/>
+<rule ref="Generic.Functions.CallTimePassByReference"/>
+<rule ref="Generic.Functions.OpeningFunctionBraceBsdAllman"/>
+<rule ref="Generic.Metrics.CyclomaticComplexity">
+    <properties>
+        <property name="complexity" value="15"/>
+        <property name="absoluteComplexity" value="25"/>
+    </properties>
+</rule>
+<rule ref="Generic.Metrics.NestingLevel">
+    <properties>
+        <property name="nestingLevel" value="4"/>
+        <property name="absoluteNestingLevel" value="11"/>
+    </properties>
+</rule>
+<rule ref="Generic.NamingConventions.ConstructorName"/>
+<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
+<rule ref="Generic.NamingConventions.CamelCapsFunctionName">
+    <exclude-pattern>*StringUtils.php</exclude-pattern><!-- Implements missing default functions -->
+</rule>
+<rule ref="Generic.PHP.LowerCaseConstant"/>
+<rule ref="Generic.PHP.NoSilencedErrors"/>
+<rule ref="Generic.Strings.UnnecessaryStringConcat"/>
+<rule ref="Generic.WhiteSpace.DisallowTabIndent"/>
+<rule ref="MySource.PHP.EvalObjectFactory"/>
+<rule ref="MySource.PHP.GetRequestData"/>
+<rule ref="PEAR.Classes.ClassDeclaration"/>
+<!--<rule ref="PEAR.Commenting.FunctionComment"/> problem with inheritdocblock-->
+<rule ref="PEAR.Commenting.InlineComment"/>
+<rule ref="PEAR.ControlStructures.ControlSignature"/>
+<rule ref="PEAR.ControlStructures.MultiLineCondition"/>
+<rule ref="PEAR.Functions.ValidDefaultValue"/>
+<rule ref="PSR1.Classes.ClassDeclaration"/>
+<rule ref="PSR1.Files.SideEffects">
+    <exclude-pattern>*Pdf.php</exclude-pattern><!-- Just a wrapper -->
+    <exclude-pattern>*Excel.php</exclude-pattern><!-- Just a wrapper -->
+    <exclude-pattern>*/tests/*</exclude-pattern><!-- Tests don't always have side effects -->
+</rule>
+<rule ref="PSR2.Classes.ClassDeclaration"/>
+<rule ref="PSR2.Classes.PropertyDeclaration"/>
+<rule ref="PSR2.ControlStructures.ControlStructureSpacing"/>
+<rule ref="PSR2.ControlStructures.ElseIfDeclaration"/>
+<rule ref="PSR2.ControlStructures.SwitchDeclaration"/>
+<rule ref="PSR2.Files.EndFileNewline"/>
+<rule ref="PSR2.Methods.MethodDeclaration"/>
+<rule ref="PSR2.Namespaces.NamespaceDeclaration"/>
+<rule ref="PSR2.Namespaces.UseDeclaration"/>
+<rule ref="Squiz.PHP.NonExecutableCode"/>
+<rule ref="Squiz.Scope.StaticThisUsage"/>
+<rule ref="Squiz.WhiteSpace.CastSpacing"/>
+<rule ref="Squiz.WhiteSpace.LanguageConstructSpacing"/>
+<rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing"/>
+<rule ref="Squiz.WhiteSpace.OperatorSpacing"/>
+<rule ref="Squiz.WhiteSpace.ScopeKeywordSpacing"/>
+<rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
+<rule ref="Zend.Files.ClosingTag"/>
+</ruleset>
\ No newline at end of file
diff --git a/Config/phpmd.xml b/Config/phpmd.xml
new file mode 100644
index 0000000..bcb7a39
--- /dev/null
+++ b/Config/phpmd.xml
@@ -0,0 +1,88 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="default" 
+    xmlns="http://pmd.sf.net/ruleset/1.0.0" 
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
+    xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
+    xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
+<description></description>
+<rule ref="rulesets/codesize.xml/CyclomaticComplexity">
+    <properties>
+        <property name="reportLevel" value="15"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/NPathComplexity">
+    <properties>
+        <property name="minimum" value="200"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/ExcessiveMethodLength">
+    <properties>
+        <property name="minimum" value="30"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/ExcessiveClassLength">
+    <properties>
+        <property name="minimum" value="900"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/ExcessiveParameterList">
+    <properties>
+        <property name="minimum" value="5"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/ExcessivePublicCount">
+    <properties>
+        <property name="minimum" value="50"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/TooManyMethods">
+    <properties>
+        <property name="maxmethods" value="30"/>
+    </properties>
+</rule>
+<rule ref="rulesets/codesize.xml/ExcessiveClassComplexity">
+    <properties>
+        <property name="maximum" value="100"/>
+    </properties>
+</rule>
+<rule ref="rulesets/controversial.xml"/>
+<rule ref="rulesets/design.xml/ExitExpression"/>
+<rule ref="rulesets/design.xml/EvalExpression"/>
+<rule ref="rulesets/design.xml/GotoStatement"/>
+<rule ref="rulesets/design.xml/NumberOfChildren">
+    <properties>
+        <property name="minimum" value="10"/>
+    </properties>
+</rule>
+<rule ref="rulesets/design.xml/DepthOfInheritance">
+    <properties>
+        <property name="minimum" value="5"/>
+    </properties>
+</rule>
+<rule ref="rulesets/design.xml/CouplingBetweenObjects">
+    <properties>
+        <property name="minimum" value="15"/>
+    </properties>
+</rule>
+<rule ref="rulesets/naming.xml/ShortVariable">
+    <properties>
+        <property name="minimum" value="3"/>
+    </properties>
+</rule>
+<rule ref="rulesets/naming.xml/LongVariable">
+    <properties>
+        <property name="maximum" value="30"/>
+    </properties>
+</rule>
+<rule ref="rulesets/naming.xml/ShortMethodName">
+    <properties>
+        <property name="minimum" value="3"/>
+    </properties>
+</rule>
+<rule ref="rulesets/naming.xml/ConstructorWithNameAsEnclosingClass"/>
+<rule ref="rulesets/naming.xml/ConstantNamingConventions"/>
+<rule ref="rulesets/naming.xml/BooleanGetMethodName"/>
+<rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/>
+<rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
+<rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/>
+</ruleset>
\ No newline at end of file