From 2b1be588ea9182549e3199562a2be065ec7c36db Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Fri, 8 Dec 2023 21:52:22 +0000
Subject: [PATCH] bug fixes

---
 Config/phpcs.xml                | 23 +++++++++++------------
 Helper/Scripts/serverInstall.sh |  2 +-
 2 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/Config/phpcs.xml b/Config/phpcs.xml
index 843e603..57516f1 100755
--- a/Config/phpcs.xml
+++ b/Config/phpcs.xml
@@ -27,17 +27,16 @@
 <exclude-pattern>*/tests/*</exclude-pattern>
 <exclude-pattern>*/Sandbox/*</exclude-pattern>
 <exclude-pattern>*/vendor/*</exclude-pattern>
-<exclude-pattern>*/OAuth2/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/Mail/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/Interfaces/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/Workflows/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/Accounting/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/JobScheduling/*</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/TrueSkill.php</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/BayesianPersonalizedRanking.php</exclude-pattern><!-- @todo: temporarily disabled-->
-<exclude-pattern>*/Parser/Spreadsheet/*</exclude-pattern><!-- @note: false positive due to libs -->
-<exclude-pattern>*/Parser/Presentation/*</exclude-pattern><!-- @note: false positive due to libs -->
-<exclude-pattern>*/Parser/Document/*</exclude-pattern><!-- @note: false positive due to libs -->
+<exclude-pattern>*/Mail/*</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/Interfaces/*</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/Workflows/*</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/Accounting/*</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/JobScheduling/*</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/TrueSkill.php</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/BayesianPersonalizedRanking.php</exclude-pattern><!-- @todo temporarily disabled-->
+<exclude-pattern>*/Parser/Spreadsheet/*</exclude-pattern><!-- false positive due to libs -->
+<exclude-pattern>*/Parser/Presentation/*</exclude-pattern><!-- false positive due to libs -->
+<exclude-pattern>*/Parser/Document/*</exclude-pattern><!-- false positive due to libs -->
 <exclude-pattern>*Hooks.php</exclude-pattern>
 <exclude-pattern>*Markdown.js</exclude-pattern>
 <exclude-pattern>*ObjLoader.js</exclude-pattern>
@@ -50,7 +49,7 @@
 <arg value="q"/>
 <arg name="colors"/>
 <arg name="tab-width" value="4"/>
-<!-- <rule ref="Generic.Classes.DuplicateClassName"/> @todo: disabled until bug is fixed. currently namespace is ignored which creates a lot of false positives e.g. Installer, Updater, Controller, etc. -->
+<!-- <rule ref="Generic.Classes.DuplicateClassName"/> @todo disabled until bug is fixed. currently namespace is ignored which creates a lot of false positives e.g. Installer, Updater, Controller, etc. -->
 <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
 <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall">
     <exclude-pattern>*Sort.php</exclude-pattern>
diff --git a/Helper/Scripts/serverInstall.sh b/Helper/Scripts/serverInstall.sh
index 1eaa558..d8389ed 100644
--- a/Helper/Scripts/serverInstall.sh
+++ b/Helper/Scripts/serverInstall.sh
@@ -26,7 +26,7 @@ service fail2ban restart
 
 # SSH
 
-# TODO: upload ssh key and disable password login if successful
+# upload ssh key and disable password login if successful
 # https://www.digitalocean.com/community/tutorials/how-to-set-up-ssh-keys-on-ubuntu-20-04
 
 # copy the public key (e.g. *.pub to the file ~/.ssh/authorized_keys of the respective user)