From 133657830417f4b2a6e52dc3035f898b57a214f0 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Sun, 24 Oct 2021 13:18:08 +0200 Subject: [PATCH] get overall coverage to 76% --- Helper/findMissingNullModelTest.php | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Helper/findMissingNullModelTest.php b/Helper/findMissingNullModelTest.php index 232e79e..71c5004 100644 --- a/Helper/findMissingNullModelTest.php +++ b/Helper/findMissingNullModelTest.php @@ -34,8 +34,18 @@ foreach ($modules as $module) { continue; } - if (!\is_file(__DIR__ . '/../../Modules/' . $module . '/tests/Models/' . $model)) { - echo $module . ': ' . $model . "\n"; + if (\stripos($model, '.php') === false) { + throw \Exception('invalid substr'); + } + + $model = \substr($model, 4, -4); // remove Null and .php from string + + if (empty($model)) { + throw \Exception('invalid substr'); + } + + if (!\is_file(__DIR__ . '/../../Modules/' . $module . '/tests/Models/Null' . $model . 'Test.php')) { + echo $module . ': Null' . $model . "\n"; if (!\is_dir(__DIR__ . '/../../Modules/' . $module . '/tests')) { \mkdir(__DIR__ . '/../../Modules/' . $module . '/tests'); @@ -45,8 +55,6 @@ foreach ($modules as $module) { \mkdir(__DIR__ . '/../../Modules/' . $module . '/tests/Models'); } - $model = \substr($model, 4, -4); // remove Null and .php from string - $test = '